Update the Policy CRDs and roles

[mprahl]

Relates:
open-cluster-management-io/governance-policy-propagator#88
https://issues.redhat.com/browse/ACM-2946

[mprahl]

/cc @dhaiducek

[dhaiducek]

Oh man, I've been neglecting clusteradm updates--we're missing the consolidated sync containers and the PolicyDependency keys here. Do you want to handle all of the reconciles in this PR or would you like to merge this one and I can open a separate PR to handle the rest?

[mprahl]

@dhaiducek thanks for the reminder. I just synced the Policy CRD as well.

[mikeshng]

CC @ycyaoxdu

[dhaiducek]

Thanks! Would you also remove the sync images from the addon-controller deployment:

            - name: GOVERNANCE_POLICY_SPEC_SYNC_IMAGE
              value: quay.io/open-cluster-management/governance-policy-spec-sync:{{ .BundleVersion.PolicyAddon }}
            - name: GOVERNANCE_POLICY_STATUS_SYNC_IMAGE
              value: quay.io/open-cluster-management/governance-policy-status-sync:{{ .BundleVersion.PolicyAddon }}
            - name: GOVERNANCE_POLICY_TEMPLATE_SYNC_IMAGE
              value: quay.io/open-cluster-management/governance-policy-template-sync:{{ .BundleVersion.PolicyAddon }}

There were some other minor role updates, but I think they're only relevant to Openshift.

[mprahl]

name: GOVERNANCE_POLICY_SPEC_SYNC_IMAGE

@dhaiducek I thought we kept those to be able to install older versions of OCM with the latest clusteradm?

[dhaiducek]

Oh yeah--we'll definitely need them for backward compatibility. Good call.

[mprahl]

@dhaiducek I synced the addon controller and propagator ClusterRoles. Was there anything else that was out of sync?

[dhaiducek]

LGTM! Thanks for the updates, @mprahl!

[dhaiducek]

@mprahl The rebase should pick up the OWNERS file that I added, and then we can get the approval for this PR. It looks like your branch doesn't have the commit yet:

• Add addon OWNERS files #301

[dhaiducek]

Might need a force-push or no-op here. I'm not sure why the e2e-test failed.

[mprahl]

Might need a force-push or no-op here. I'm not sure why the e2e-test failed.

I saw that. I just force pushed again but I noticed another open PR has the same issue.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cmd/install/hubaddon/OWNERS [dhaiducek,mprahl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment