Skip to content

fix: don't throw when there are no commands #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

gustavohenke
Copy link
Member

There's a guard against no inputs in

assert.notStrictEqual(baseCommands.length, 0, '[concurrently] no commands provided');

However, there can still a situation where are no commands to run if one of the inputs is a wildcard that doesn't expand to anything.
This has been detected as the cause of #527, though it's not a fix for it. CompletionListener should simply assume that no commands = success.

@coveralls
Copy link

Coverage Status

coverage: 98.186% (+0.006%) from 98.18%
when pulling d599be5 on no-commands
into 4ffe63b on main.

@gustavohenke gustavohenke merged commit 11500d4 into main Feb 22, 2025
21 checks passed
@gustavohenke gustavohenke deleted the no-commands branch February 22, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants