Shared layer surface area function #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test for function and fixed function
jcurtis2
approved these changes
Apr 14, 2025
mattldawson
requested changes
Apr 21, 2025
mattldawson
requested changes
Apr 28, 2025
…d surface_area funtion in modal/binned c code -- needs work
Co-authored-by: Matt Dawson <[email protected]>
mattldawson
requested changes
May 19, 2025
| CONC_water / DENSITY_water + | ||
| CONC_salt / DENSITY_salt ); // volume density of layer 3 (m3/m3) | ||
|
|
||
| double eff_rad_expected = pow( ( 3.0 / 4.0 / 3.14159265359 * volume_density ), 1.0/3.0 ); |
There was a problem hiding this comment.
This looks like it is the surface area of the whole particle (based on the total volume of the particle). I think this should actually be the surface area of the second layer from the center (calculated by summing the total volume of the core and the middle layer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To transfer mass between layers, the diffusion rxn will require diffusion fluxes multiplied by the inter-facial area shared between the layers. The mass transfer between layers is based on the flux equations described in Shiraiwa et al. (2012). This PR adds the surface area computation to the single particle aerosol representation.
This function, a prerequisite for the diffusion rxn, computes the surface area of the inter-facial layer considered. The diffusion rxn has not yet been added to the code. The function inputs include the aero_phase_idx_first and aero_phase_idx_second associated with the inner and outer layer phase considered in the mass transfer, respectively. These input phases are output from the adjacent_phases function, which checks if two phases are in adjacent layers and indicates associated phase pairs (index_pairs variable).
When multiple phases exist in the same layer, the surface area shared by the adjacent phases considered will scale according to volume occupied by a phases in their associated layers. The phase configuration chosen is known as "fractional volume overlap", meaning the surface area is multiplied by the fractional overlap
f_first * f_second * total_interface_surface_areawheref_first = volume_phase_first / volume_total_layer_firstandf_second = volume_phase_second / volume_total_layer_second.