Develop surface reaction #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K20shores
reviewed
May 16, 2023
src/rxns/rxn_surface.F90
Outdated
| end do | ||
| end do | ||
|
|
||
| allocate(this%condensed_data_int(NUM_INT_PROP_ + 2 + 3 * products%size() + & |
There was a problem hiding this comment.
Could you leave a comment here and for the following allocate statement on what the constants are (+2 + 3 *)?
K20shores
approved these changes
May 16, 2023
jcurtis2
approved these changes
May 16, 2023
src/rxns/rxn_surface.c
Outdated
|
|
||
| /** \brief Update reaction data for new environmental conditions | ||
| * | ||
| * For surface reactions this only involves recalculating the rate |
There was a problem hiding this comment.
This doesn't appear to be true for this.
There was a problem hiding this comment.
updated the comment
src/rxns/rxn_surface.c
Outdated
| double *float_data = rxn_float_data; | ||
| double *env_data = model_data->grid_cell_env; | ||
|
|
||
| // save the mean free path [m] for calculating condensation rates |
There was a problem hiding this comment.
Looks like this is mean speed and not mean free path.
There was a problem hiding this comment.
updated the comment
src/util.h
Outdated
| @@ -150,4 +161,58 @@ static inline double d_gas_aerosol_rxn_rate_constant_d_radius( | |||
| mean_free_path__m, radius__m, alpha)); | |||
| } | |||
|
|
|||
| /** Calculate the gas-aerosol reaction rate for the continuum regime | |||
There was a problem hiding this comment.
Can we add some sort of citation for the source of this equation?
There was a problem hiding this comment.
added citation to Tie et al. 2003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a surface reaction type for gas phase species:
where X, Y, and Z are gas-phase species and the reaction rate depends on total particle surface area for a given aerosol phase.