Relevance of SHARED option in CMakeLists "add_library" function #9
Comments
jtgasparik
added a commit
that referenced
this issue
Feb 18, 2025
* addition of is_at_surface flag to num_phase_instances function * testing partmc coupling * testing * fixed num_phase_instances function, now passes * fixed function and added test * one more test * testing * reverting change * changes to phase_id function * deleted duplicate num_instances variable * testing SIMPOL reaction with multiple layers added to the json - currently failing * update unique names function to have is_at_surface flag * remote diagnostic output * added test for unique_name function * ive broken the SIMPOL rxn again by adding layers * adding mass * minor changes to SIMPOl test * fix to write statement - still not passing tests * added tests for phase_ids function to single particle * test added for phase id for modal/binned rep * added second particle to test suite for single particle c test - in progress * adding unit tests to single particle c functions with multiple particles and different layers -- in progress * adding second particle to single particle c tests -- in progress and failing * adding another test particle and phase to single particle test aero rep test -- in progress * testing the same phase in a different particle works. testing a different phase in a different particle is in-progress * testing differnt particles and different layers * second test phase added -- failing for test phase 1 and 3 * print statements to repo * modified print statements * update calls to aero phase functions (#9) * MULTIPLE LAYERS WORK - fix to tests * SIMPOL with two layers and some mass in second layer * added test to SIMPOL * added HL test with multiple layers, plus minor SIMPOL test changes * one edit * testing HL with mass in layer 2 * test from new laptop and fix to small typo * another test and fix to typo * Update src/aero_rep_data.F90 Co-authored-by: Matt Dawson <[email protected]> * Update src/aero_reps/aero_rep_single_particle.F90 Co-authored-by: Matt Dawson <[email protected]> * resolving comment * fixes to PR * Update src/aero_reps/aero_rep_single_particle.F90 Co-authored-by: Matt Dawson <[email protected]> --------- Co-authored-by: Matt Dawson <[email protected]> Co-authored-by: Matt Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello @mattldawson ,
I'm merging some changes on CMakeLists from the main branch to my branch, and in the process this warning triggers when compiling with GPU:
nvlink warning : SM Arch ('sm_30') not found in 'CMakeFiles/camplib.dir/src/cuda/camp_gpu_solver.cu.o'Seems this warning is triggered by setting the SHARED option from "add_library" function, like this:
What is the relevante of SHARED option? It is needed for some test or the fix can be delayed to some point in the future?
The text was updated successfully, but these errors were encountered: