Skip to content

Add sectional and exact simulations plus aero_binned type #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 23, 2025

Conversation

jcurtis2
Copy link
Member

@jcurtis2 jcurtis2 commented Apr 6, 2025

RunSect and RunSectOpt allow sectional simulations. RunExact and RunExactOpt allow for exact simulation, which can be used to solve the additive coagulation kernel example. Added AeroBinned as both these cases need them to track number and volume concentration of each size bin.

Closes #65

@jcurtis2 jcurtis2 self-assigned this Apr 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.76%. Comparing base (8ba1e54) to head (96ecea4).

Files with missing lines Patch % Lines
src/run_exact_opt.hpp 83.33% 1 Missing and 1 partial ⚠️
src/run_sect_opt.F90 93.10% 1 Missing and 1 partial ⚠️
src/run_exact_opt.F90 95.65% 0 Missing and 1 partial ⚠️
src/run_sect_opt.hpp 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   90.13%   90.76%   +0.63%     
==========================================
  Files          45       55      +10     
  Lines        2270     2491     +221     
  Branches      127      135       +8     
==========================================
+ Hits         2046     2261     +215     
- Misses        156      158       +2     
- Partials       68       72       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Member

slayoo commented Apr 9, 2025

@emmacware, this PR includes access to the Bott scheme in PartMC!

@jcurtis2 jcurtis2 requested a review from slayoo April 11, 2025 15:01
@jcurtis2 jcurtis2 marked this pull request as ready for review April 11, 2025 15:01
@slayoo slayoo added this pull request to the merge queue Apr 23, 2025
Merged via the queue into open-atmos:main with commit 68e48e1 Apr 23, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrappers for run_exact and run_sectional
3 participants