Skip to content

importDocument created from begin() #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danielsetreus opened this issue May 21, 2019 · 1 comment
Closed

importDocument created from begin() #213

danielsetreus opened this issue May 21, 2019 · 1 comment
Labels

Comments

@danielsetreus
Copy link

danielsetreus commented May 21, 2019

When creating dynamic documents it's really useful to be able to import a document containing only child elements. Consider:

import { XMLElementOrXMLNode, create, begin } from "xmlbuilder";

const doc = begin();
const boldDoc = create('b');
boldDoc.text('Hello World');

doc.importDocument(boldDoc);

const main = create('p');
main.importDocument(doc);

console.log(main.toString());

I would expect this to result in XML document

<p><b>Hello World</b></p>

Instead I get an error: Cannot read property 'clone' of undefined (/node_modules/xmlbuilder/lib/XMLNode.js:569:32).

doc is not undefined:

console.log(doc.toString()); // <b>Hello World</b>

However doc.root() returns undefined, causing the issue.

Not sure if this is a bug or not, but reading the docs this is not what I was expecting :/

@oozcitak
Copy link
Owner

Certainly a bug. I'll take a look. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants