Skip to content

Enable Test List Editor users to view and respond to PR comments/feedback #59

Open
@agrabeli

Description

@agrabeli

Problem

The Test List Editor was primarily designed for non-GitHub users, but once their contribution ends up as a pull request on GitHub, they are unlikely to interact with their pull request (which would require the creation of a GitHub account).

Most test list pull requests involve discussion between reviewers and contributors, where reviewers share feedback for changes, explain why they may not be willing to merge the specific pull request, or make other proposals. Based on this feedback, contributors often make changes to their pull requests before they are eventually merged. All of these discussions take place in the pull request comments, which Test List Editor users are unlikely to see or respond to, since they're not GitHub users.

As a result, there is the risk that pull requests may end up getting rejected without discussion, or without enabling contributors to make improvements so that their pull requests are merged. Ultimately, this may dis-encourage contributions, as contributors may be left confused about why their contributions are not integrated into the test lists.

Going forward

I this it's important that we explore ways to enable Test List Editor users to:

  • View comments/feedback by test list reviewers
  • Respond to reviewer comments/feedback without having to create GitHub accounts

This need was also highlighted by a community member on the OONI Slack channel today.

Metadata

Metadata

Assignees

Labels

enhancementNew feature request or improvement to existing functionalityiceboxpriority/lowNice to haveuser feedbackrequests that have been added to the backlog as a direct result of user feedback or testing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions