ExLlamav2_HF: Convert logits to FP32 #4310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/exllamav2.py # requirements.txt # requirements_amd.txt # requirements_amd_noavx2.txt # requirements_apple_intel.txt # requirements_apple_silicon.txt # requirements_cpu_only.txt # requirements_cpu_only_noavx2.txt # requirements_noavx2.txt # requirements_nowheels.txt
|
PPL on evaluation went down slightly after this. |
|
Thanks @turboderp, I would never have noticed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExLlama converts logits to FP32 at the end of the forward pass, while ExLlamaV2 returns FP16 logits straight from the lm_head layer. Converting in the V2 loader makes sure the HF sampler behavior the same for V1 and V2.
Checklist: