Skip to content

feat: Add ability to specify vertex-ai model location #4955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 11, 2025

Conversation

raunakab
Copy link
Contributor

@raunakab raunakab commented Jun 27, 2025

Description

This PR enables the ability to specify the location of the vertex-ai model location.

Addresses: https://linear.app/danswer/issue/DAN-2148/add-ability-to-specify-vertex-ai-model-location.

Screenshot

image

How Has This Been Tested?

Manually tested.

@raunakab raunakab requested a review from a team as a code owner June 27, 2025 00:23
Copy link

vercel bot commented Jun 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 6:09pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Adds support for specifying Google Cloud Vertex AI model locations, enabling more flexible deployment configurations across different GCP regions.

  • Added new VERTEX_LOCATION_KWARG in backend/onyx/llm/chat_llm.py to support custom GCP region specification
  • Renamed VERTEX_CREDENTIALS_KWARG to VERTEX_CREDENTIALS_FILE_KWARG in backend/onyx/llm/chat_llm.py for better clarity
  • Extracted key_type into separate CustomConfigKeyType type alias in web/src/app/admin/configuration/llm/interfaces.ts for improved code reuse
  • Reorganized model kwargs handling in backend/onyx/llm/chat_llm.py to cleanly process both credentials and location parameters

3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@raunakab raunakab requested a review from evan-onyx July 11, 2025 19:26
@raunakab raunakab disabled auto-merge July 11, 2025 23:16
@raunakab raunakab merged commit 89f9256 into main Jul 11, 2025
14 checks passed
@raunakab raunakab deleted the feat/model-locations branch July 11, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant