-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Add ability to specify vertex-ai model location #4955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Adds support for specifying Google Cloud Vertex AI model locations, enabling more flexible deployment configurations across different GCP regions.
- Added new
VERTEX_LOCATION_KWARG
inbackend/onyx/llm/chat_llm.py
to support custom GCP region specification - Renamed
VERTEX_CREDENTIALS_KWARG
toVERTEX_CREDENTIALS_FILE_KWARG
inbackend/onyx/llm/chat_llm.py
for better clarity - Extracted
key_type
into separateCustomConfigKeyType
type alias inweb/src/app/admin/configuration/llm/interfaces.ts
for improved code reuse - Reorganized model kwargs handling in
backend/onyx/llm/chat_llm.py
to cleanly process both credentials and location parameters
3 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Description
This PR enables the ability to specify the location of the vertex-ai model location.
Addresses: https://linear.app/danswer/issue/DAN-2148/add-ability-to-specify-vertex-ai-model-location.
Screenshot
How Has This Been Tested?
Manually tested.