Deep Research UI #4887
Draft
Deep Research UI #4887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drew-harris is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements a new Deep Research mode in the chat interface, adding advanced research capabilities with web search, command execution, and email functionality.
- New Deep Research toggle added to
web/src/app/chat/input/ChatInputBar.tsxwith mutual exclusivity to pro search mode - Added
DeepResearchMessageandDeepActionscomponents in/web/src/app/chatfor handling various research actions (web search, email, commands) - Introduced type-safe action handling system in
deepResearchAction.tsfor managing different research operations - Extended existing Message interface in
interfaces.tsto track deep research state and actions - Testing implementation currently uses mock data (
drewMock.ts,mockConstants.ts) for UI development
13 files reviewed, 13 comments
Edit PR Review Bot Settings | Greptile
Comment on lines
+68
to
+71
| if ("collapsed" in action) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
style: Simplify isCollapsible to a one-liner: return 'collapsed' in action
Suggested change
| if ("collapsed" in action) { | |
| return true; | |
| } | |
| return false; | |
| return "collapsed" in action; |
Comment on lines
+91
to
+96
| yield buildActionPacket("run_command", { | ||
| id: "parse-nike", | ||
| cmd: `curl https://www.nike.com/`, | ||
| result: longHtml, | ||
| collapsed: false, | ||
| }); |
There was a problem hiding this comment.
logic: Duplicate call to parse-nike command with identical parameters. First call at line 75 returns empty result, this one returns longHtml. Inconsistent behavior may cause test flakiness
Comment on lines
+127
to
+130
| await delay(200); | ||
| yield { | ||
| answer_piece: word + " ", | ||
| }; |
There was a problem hiding this comment.
style: Adding a space after each word creates extra trailing space in final result. Consider trimming or joining words with space instead
Comment on lines
+34
to
+38
| ${ | ||
| enabled | ||
| ? "border-background-200 group-hover:border-[#000] dark:group-hover:border-neutral-300" | ||
| : "border-background-200 group-hover:border-[#000] dark:group-hover:border-neutral-300" | ||
| } |
There was a problem hiding this comment.
style: The enabled/disabled states have identical CSS classes. Redundant ternary that can be simplified to a single string.
Suggested change
| ${ | |
| enabled | |
| ? "border-background-200 group-hover:border-[#000] dark:group-hover:border-neutral-300" | |
| : "border-background-200 group-hover:border-[#000] dark:group-hover:border-neutral-300" | |
| } | |
| border-background-200 group-hover:border-[#000] dark:group-hover:border-neutral-300 |
Comment on lines
+196
to
+198
| // @ts-ignore | ||
| onClick={() => props!.handleFeedback("like")} | ||
| /> |
There was a problem hiding this comment.
logic: Remove @ts-ignore and properly type the props. This indicates a type mismatch that should be fixed rather than ignored.
Comment on lines
+9
to
+12
| interface DeepToggleProps { | ||
| enabled: boolean; | ||
| setEnabled: (enabled: boolean) => void; | ||
| } |
There was a problem hiding this comment.
style: Props interface named 'DeepToggleProps' while component is 'DeepResearchToggle'. Consider renaming to 'DeepResearchToggleProps' for consistency.
Comment on lines
+150
to
+162
| {props.content ? ( | ||
| <> | ||
| {typeof props.content === "string" ? ( | ||
| <div className="overflow-x-visible max-w-content-max"> | ||
| {props.content} | ||
| </div> | ||
| ) : ( | ||
| <div>{props.content}</div> | ||
| )} | ||
| </> | ||
| ) : props.isComplete ? null : ( | ||
| <></> | ||
| )} |
There was a problem hiding this comment.
style: Simplify this nested ternary with multiple empty fragments into a cleaner conditional render
| @@ -180,6 +182,7 @@ export interface SendMessageParams { | |||
| userFileIds?: number[]; | |||
| userFolderIds?: number[]; | |||
| useLanggraph?: boolean; | |||
| useDeepResearch?: boolean; | |||
There was a problem hiding this comment.
logic: useDeepResearch added to interface but not used in sendMessage function body. Add this to the request body in sendMessage to enable the feature.
Suggested change
| useDeepResearch?: boolean; | |
| export async function* sendMessage({ | |
| regenerate, | |
| message, | |
| fileDescriptors, | |
| userFileIds, | |
| userFolderIds, | |
| parentMessageId, | |
| chatSessionId, | |
| filters, | |
| selectedDocumentIds, | |
| queryOverride, | |
| forceSearch, | |
| modelProvider, | |
| modelVersion, | |
| temperature, | |
| systemPromptOverride, | |
| useExistingUserMessage, | |
| alternateAssistantId, | |
| signal, | |
| useLanggraph, | |
| useDeepResearch, | |
| }: SendMessageParams): AsyncGenerator<PacketType, void, unknown> { |
Comment on lines
+1134
to
+1136
| const messagePromise = params.useDeepResearch | ||
| ? mockSendMessage(params) | ||
| : sendMessage(params); |
There was a problem hiding this comment.
logic: Make sure to remove mockSendMessage before merging to production
| @@ -0,0 +1,3 @@ | |||
| export const longHtml = ` | |||
| <!DOCTYPE html><html lang="en-US"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=2.0"/><meta name="keywords" content="nike"/><meta name="robots" content="index, follow"/><meta name="description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta http-equiv="content-language" content="en-US"/><meta name="application-name" content="Nike.com"/><meta property="og:description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta property="og:image" content="https://c.static-nike.com/a/images/w_1920,c_limit/bzl2wmsfh7kgdkufrrjq/image.jpg"/><meta property="og:locale" content="en-US"/><meta property="og:site_name" content="Nike.com"/><meta property="og:title" content="Nike. Just Do It"/><meta property="og:type" content="website"/><meta property="og:url" content="https://www.nike.com/?cid=4942550&cp=usns_aff_nike__PID_100481284_Afterpay+US+Inc&cjevent=44610f7447e711f082d100ae0a1cb827&_forward_params=1&pcn=cj_mobile_inactivity-0d&_smtype=3&psid=100481284&pcrn=CJ&cl=44610f7447e711f082d100ae0a1cb827&pcrid=17047842&psn=Afterpay+US+Inc"/><meta name="twitter:card" content="summary_large_image"/><meta name="twitter:creator" content="@nike"/><meta name="twitter:description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta name="twitter:image" content="https://c.static-nike.com/a/images/w_1920,c_limit/bzl2wmsfh7kgdkufrrjq/image.jpg"/><meta name="twitter:site" content="@nike"/><meta name="twitter:title" content="Nike. Just Do It"/><link href="https://www.nike.com/favicon.ico?v=1" rel="icon" type="image/x-icon"/><link href="https://www.nike.com/android-icon-192x192.png" rel="icon" sizes="192x192" type="image/png"/><link href="https://www.nike.com/android-icon-128x128.png" rel="icon" sizes="128x128" type="image/png"/><link href="https://www.nike.com/apple-touch-icon.png" rel="apple-touch-icon" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-76x76-precomposed.png" rel="apple-touch-icon" sizes="76x76" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-120x120-precomposed.png" rel="apple-touch-icon" sizes="120x120" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-152x152-precomposed.png" rel="apple-touch-icon" sizes="152x152" type="image/png"/><link href="https://insights-collector.newrelic.com/" rel="dns-prefetch"/><link href="https://c.static-nike.com/" rel="dns-prefetch"/><link href="https://cdnjs.cloudflare.com/" rel="dns-prefetch"/><link href="https://secure-store.nike.com/" rel="dns-prefetch"/><link href="https://web.nike.com/" rel="dns-prefetch"/><link href="https://static.nike.com/" rel="dns-prefetch"/><link href="https://api.segment.io/" rel="dns-prefetch"/><link href="https://api.nike.com" rel="dns-prefetch"/><link href="https://connect.facebook.net/" rel="dns-prefetch"/><link href="https://analytics.nike.com/" rel="dns-prefetch"/><link as="font" crossorigin="crossorigin" href="https://www.nike.com/static/ncss/5.0/dotcom/fonts/Nike-Futura.woff2" rel="preload" type="font/woff2"/><link href="https://www.nike.com/" rel="canonical"/><title>Nike. Just Do It. Nike.com</title><meta name="next-head-count" content="40"/><script id="new-relic-browser-agent" type="text/javascript">window.NREUM||(NREUM={});NREUM.info = {"agent":"","beacon":"bam.nr-data.net","errorBeacon":"bam.nr-data.net","licenseKey":"NRBR-d074912dd348988f83d","applicationID":"175756206","agentToken":null,"applicationTime":151.116167,"transactionName":"ZVdXbUtXXBIHVUNfXlwde1ZLW1MND0xSUmRAWxoT","queueTime":0,"ttGuid":"5f1693e395762bf5"}; (window.NREUM||(NREUM={})).init={privacy:{cookies_enabled:true},ajax:{deny_list:["bam.nr-data.net"]}};(window.NREUM||(NREUM={})).loader_config={xpid:"UwcDVlVUGwIHUVZXAQMHUA==",licenseKey:"NRBR-d074912dd348988f83d",applicationID:"175756206"};;/* | |||
There was a problem hiding this comment.
logic: Remove trailing ellipsis ('/*') at the end of the HTML string - it appears to be incomplete and could cause parsing issues
Suggested change
| <!DOCTYPE html><html lang="en-US"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=2.0"/><meta name="keywords" content="nike"/><meta name="robots" content="index, follow"/><meta name="description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta http-equiv="content-language" content="en-US"/><meta name="application-name" content="Nike.com"/><meta property="og:description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta property="og:image" content="https://c.static-nike.com/a/images/w_1920,c_limit/bzl2wmsfh7kgdkufrrjq/image.jpg"/><meta property="og:locale" content="en-US"/><meta property="og:site_name" content="Nike.com"/><meta property="og:title" content="Nike. Just Do It"/><meta property="og:type" content="website"/><meta property="og:url" content="https://www.nike.com/?cid=4942550&cp=usns_aff_nike__PID_100481284_Afterpay+US+Inc&cjevent=44610f7447e711f082d100ae0a1cb827&_forward_params=1&pcn=cj_mobile_inactivity-0d&_smtype=3&psid=100481284&pcrn=CJ&cl=44610f7447e711f082d100ae0a1cb827&pcrid=17047842&psn=Afterpay+US+Inc"/><meta name="twitter:card" content="summary_large_image"/><meta name="twitter:creator" content="@nike"/><meta name="twitter:description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta name="twitter:image" content="https://c.static-nike.com/a/images/w_1920,c_limit/bzl2wmsfh7kgdkufrrjq/image.jpg"/><meta name="twitter:site" content="@nike"/><meta name="twitter:title" content="Nike. Just Do It"/><link href="https://www.nike.com/favicon.ico?v=1" rel="icon" type="image/x-icon"/><link href="https://www.nike.com/android-icon-192x192.png" rel="icon" sizes="192x192" type="image/png"/><link href="https://www.nike.com/android-icon-128x128.png" rel="icon" sizes="128x128" type="image/png"/><link href="https://www.nike.com/apple-touch-icon.png" rel="apple-touch-icon" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-76x76-precomposed.png" rel="apple-touch-icon" sizes="76x76" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-120x120-precomposed.png" rel="apple-touch-icon" sizes="120x120" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-152x152-precomposed.png" rel="apple-touch-icon" sizes="152x152" type="image/png"/><link href="https://insights-collector.newrelic.com/" rel="dns-prefetch"/><link href="https://c.static-nike.com/" rel="dns-prefetch"/><link href="https://cdnjs.cloudflare.com/" rel="dns-prefetch"/><link href="https://secure-store.nike.com/" rel="dns-prefetch"/><link href="https://web.nike.com/" rel="dns-prefetch"/><link href="https://static.nike.com/" rel="dns-prefetch"/><link href="https://api.segment.io/" rel="dns-prefetch"/><link href="https://api.nike.com" rel="dns-prefetch"/><link href="https://connect.facebook.net/" rel="dns-prefetch"/><link href="https://analytics.nike.com/" rel="dns-prefetch"/><link as="font" crossorigin="crossorigin" href="https://www.nike.com/static/ncss/5.0/dotcom/fonts/Nike-Futura.woff2" rel="preload" type="font/woff2"/><link href="https://www.nike.com/" rel="canonical"/><title>Nike. Just Do It. Nike.com</title><meta name="next-head-count" content="40"/><script id="new-relic-browser-agent" type="text/javascript">window.NREUM||(NREUM={});NREUM.info = {"agent":"","beacon":"bam.nr-data.net","errorBeacon":"bam.nr-data.net","licenseKey":"NRBR-d074912dd348988f83d","applicationID":"175756206","agentToken":null,"applicationTime":151.116167,"transactionName":"ZVdXbUtXXBIHVUNfXlwde1ZLW1MND0xSUmRAWxoT","queueTime":0,"ttGuid":"5f1693e395762bf5"}; (window.NREUM||(NREUM={})).init={privacy:{cookies_enabled:true},ajax:{deny_list:["bam.nr-data.net"]}};(window.NREUM||(NREUM={})).loader_config={xpid:"UwcDVlVUGwIHUVZXAQMHUA==",licenseKey:"NRBR-d074912dd348988f83d",applicationID:"175756206"};;/* | |
| <!DOCTYPE html><html lang="en-US"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=2.0"/><meta name="keywords" content="nike"/><meta name="robots" content="index, follow"/><meta name="description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta http-equiv="content-language" content="en-US"/><meta name="application-name" content="Nike.com"/><meta property="og:description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta property="og:image" content="https://c.static-nike.com/a/images/w_1920,c_limit/bzl2wmsfh7kgdkufrrjq/image.jpg"/><meta property="og:locale" content="en-US"/><meta property="og:site_name" content="Nike.com"/><meta property="og:title" content="Nike. Just Do It"/><meta property="og:type" content="website"/><meta property="og:url" content="https://www.nike.com/?cid=4942550&cp=usns_aff_nike__PID_100481284_Afterpay+US+Inc&cjevent=44610f7447e711f082d100ae0a1cb827&_forward_params=1&pcn=cj_mobile_inactivity-0d&_smtype=3&psid=100481284&pcrn=CJ&cl=44610f7447e711f082d100ae0a1cb827&pcrid=17047842&psn=Afterpay+US+Inc"/><meta name="twitter:card" content="summary_large_image"/><meta name="twitter:creator" content="`@nike`"/><meta name="twitter:description" content="Nike delivers innovative products, experiences and services to inspire athletes."/><meta name="twitter:image" content="https://c.static-nike.com/a/images/w_1920,c_limit/bzl2wmsfh7kgdkufrrjq/image.jpg"/><meta name="twitter:site" content="`@nike`"/><meta name="twitter:title" content="Nike. Just Do It"/><link href="https://www.nike.com/favicon.ico?v=1" rel="icon" type="image/x-icon"/><link href="https://www.nike.com/android-icon-192x192.png" rel="icon" sizes="192x192" type="image/png"/><link href="https://www.nike.com/android-icon-128x128.png" rel="icon" sizes="128x128" type="image/png"/><link href="https://www.nike.com/apple-touch-icon.png" rel="apple-touch-icon" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-76x76-precomposed.png" rel="apple-touch-icon" sizes="76x76" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-120x120-precomposed.png" rel="apple-touch-icon" sizes="120x120" type="image/png"/><link href="https://www.nike.com/apple-touch-icon-152x152-precomposed.png" rel="apple-touch-icon" sizes="152x152" type="image/png"/><link href="https://insights-collector.newrelic.com/" rel="dns-prefetch"/><link href="https://c.static-nike.com/" rel="dns-prefetch"/><link href="https://cdnjs.cloudflare.com/" rel="dns-prefetch"/><link href="https://secure-store.nike.com/" rel="dns-prefetch"/><link href="https://web.nike.com/" rel="dns-prefetch"/><link href="https://static.nike.com/" rel="dns-prefetch"/><link href="https://api.segment.io/" rel="dns-prefetch"/><link href="https://api.nike.com" rel="dns-prefetch"/><link href="https://connect.facebook.net/" rel="dns-prefetch"/><link href="https://analytics.nike.com/" rel="dns-prefetch"/><link as="font" crossorigin="crossorigin" href="https://www.nike.com/static/ncss/5.0/dotcom/fonts/Nike-Futura.woff2" rel="preload" type="font/woff2"/><link href="https://www.nike.com/" rel="canonical"/><title>Nike. Just Do It. Nike.com</title><meta name="next-head-count" content="40"/><script id="new-relic-browser-agent" type="text/javascript">window.NREUM||(NREUM={});NREUM.info = {"agent":"","beacon":"bam.nr-data.net","errorBeacon":"bam.nr-data.net","licenseKey":"NRBR-d074912dd348988f83d","applicationID":"175756206","agentToken":null,"applicationTime":151.116167,"transactionName":"ZVdXbUtXXBIHVUNfXlwde1ZLW1MND0xSUmRAWxoT","queueTime":0,"ttGuid":"5f1693e395762bf5"}; (window.NREUM||(NREUM={})).init={privacy:{cookies_enabled:true},ajax:{deny_list:["bam.nr-data.net"]}};(window.NREUM||(NREUM={})).loader_config={xpid:"UwcDVlVUGwIHUVZXAQMHUA==",licenseKey:"NRBR-d074912dd348988f83d",applicationID:"175756206"}};</script></head></html> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.