Skip to content

Migrate to OWL API 4.5.25 (not released yet) #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 16, 2023
Merged

Migrate to OWL API 4.5.25 (not released yet) #1093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b88e61
Migrate to OWL API 4.5.25 (not released yet)
matentzn Feb 13, 2023
2dc1a8c
Update pom.xml
matentzn Feb 13, 2023
80e593a
Update pom.xml
matentzn Feb 15, 2023
cdc9e1d
Update pom.xml
matentzn Feb 15, 2023
40e7a32
Update CHANGELOG.md
matentzn Feb 15, 2023
41f2f8b
Merge branch 'master' into owlapi4525
matentzn Feb 16, 2023
95ca0dc
Update dropped_axiom.owl
matentzn Feb 16, 2023
613db40
Rework regression test
jamesaoverton Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
- Upgrade OWLAPI to 4.5.25 [#1093]
- Fixing OBO Serialiser erroneous logging [#1088]
- Fixing OBO Serialiser bug where built in vocabulary was introduced as annotation properties [#1089]

### Added
- Subset method added to [`extract`] [#1000]
Expand All @@ -14,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Restore logging details for CLI [#1091]

## [1.9.2] - 2023-02-09
- Upgrade OWLAPI to 4.5.24 [#1086]

### Changed
- Upgrade OWLAPI to 4.5.24 [#1086]
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
<dependency>
<groupId>net.sourceforge.owlapi</groupId>
<artifactId>owlapi-api</artifactId>
<version>4.5.24</version>
<version>4.5.25</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
Expand All @@ -176,7 +176,7 @@
<dependency>
<groupId>net.sourceforge.owlapi</groupId>
<artifactId>owlapi-apibinding</artifactId>
<version>4.5.24</version>
<version>4.5.25</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
Expand All @@ -187,7 +187,7 @@
<dependency>
<groupId>net.sourceforge.owlapi</groupId>
<artifactId>owlapi-rio</artifactId>
<version>4.5.24</version>
<version>4.5.25</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
Expand Down
13 changes: 11 additions & 2 deletions robot-command/src/test/java/org/obolibrary/robot/CommandLineIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,18 @@ public void testExecute() throws Exception {
}
runCommand(command);
}
// Regression test for dropped axiom:

// Regression test for dropped axiom should fail:
// https://github.com/ontodev/robot/issues/98
runCommand("robot convert -i dropped_axiom.owl -o " + "results/dropped_axiom.owl");
boolean passed = true;
try {
runCommand("robot convert -i dropped_axiom.owl -o " + "results/dropped_axiom.owl");
} catch (Exception e) {
passed = false;
}
if (passed) {
throw new Exception("dropped_axiom.owl test should fail but it passed");
}

compareResults();
}
Expand Down
8 changes: 4 additions & 4 deletions robot-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<excludes></excludes>
-->
<ignoreMissingClassesByRegularExpressions>
<!-- To handle sesame-rio-api-2.7.16.jar -> rdf4j-rio-api-2.4.2.jar lib change on owlapi 4.5.24 upgrade: -->
<!-- To handle sesame-rio-api-2.7.16.jar -> rdf4j-rio-api-2.4.2.jar lib change on owlapi 4.5.25 upgrade: -->
<!-- This ignore can be removed in consecutive releases -->
<ignoreMissingClassesByRegularExpression>org.openrdf.rio.*</ignoreMissingClassesByRegularExpression>
</ignoreMissingClassesByRegularExpressions>
Expand All @@ -86,7 +86,7 @@
<dependency>
<groupId>net.sourceforge.owlapi</groupId>
<artifactId>owlapi-api</artifactId>
<version>4.5.24</version>
<version>4.5.25</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
Expand All @@ -97,7 +97,7 @@
<dependency>
<groupId>net.sourceforge.owlapi</groupId>
<artifactId>owlapi-apibinding</artifactId>
<version>4.5.24</version>
<version>4.5.25</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
Expand All @@ -108,7 +108,7 @@
<dependency>
<groupId>net.sourceforge.owlapi</groupId>
<artifactId>owlapi-rio</artifactId>
<version>4.5.24</version>
<version>4.5.25</version>
<exclusions>
<exclusion>
<groupId>com.google.code.findbugs</groupId>
Expand Down