Skip to content

added support for bitwise_not op #3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

LekkalaSravya3
Copy link

Added support for the BitwiseNot operation in the ONNX to Krnl lowering path. Also included corresponding test cases in Elementwise_with_canonicalize.mlir and Elementwise_with_canonicalize_O3.mlir. This implementation addresses and
closes #3155

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a complete contribution!

@tungld
Copy link
Collaborator

tungld commented May 12, 2025

@LekkalaSravya3 when you create a commit, please sign it by git commit -s. Otherwise DCO test will fail and the PR cannot be merged. Thanks!

@LekkalaSravya3 LekkalaSravya3 marked this pull request as ready for review May 12, 2025 09:35
@LekkalaSravya3 LekkalaSravya3 requested a review from tungld May 12, 2025 09:35
@LekkalaSravya3 LekkalaSravya3 force-pushed the bitwise_not branch 2 times, most recently from 53e05a1 to 75b0391 Compare May 12, 2025 11:43
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@tungld
Copy link
Collaborator

tungld commented May 12, 2025

@jenkins-droid test this please

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@AlexandreEichenberger
Copy link
Collaborator

I see this error. Looks related to the name of the test

E   AssertionError: test name test_bitwise_not_i32_2d_cpu not found, it is likely
E             that you may have misspelled the test name or the specified test does not
E             exist in the version of onnx package you installed.
E   assert 'test_bitwise_not_i32_2d_cpu' in ['__call__', '__class__', '__delattr__', '__dict__', '__dir__', '__doc__', ...]

you can run the tests using make check-onnx-backend and one specific test using TEST_CASE_BY_USER=test_bitwise_not_i32_2d_cpu make check-onnx-backend

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@LekkalaSravya3
Copy link
Author

@LekkalaSravya3 when you create a commit, please sign it by git commit -s. Otherwise DCO test will fail and the PR cannot be merged. Thanks!

I see this error. Looks related to the name of the test

E   AssertionError: test name test_bitwise_not_i32_2d_cpu not found, it is likely
E             that you may have misspelled the test name or the specified test does not
E             exist in the version of onnx package you installed.
E   assert 'test_bitwise_not_i32_2d_cpu' in ['__call__', '__class__', '__delattr__', '__dict__', '__dir__', '__doc__', ...]

you can run the tests using make check-onnx-backend and one specific test using TEST_CASE_BY_USER=test_bitwise_not_i32_2d_cpu make check-onnx-backend

Thanks! I've updated it and confirmed that the test passes using make check-onnx-backend .

Signed-off-by: LekkalaSravya3 <[email protected]>
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LekkalaSravya3 thank you for the update! It's almost done. Just two small comments. Please make the changes. Thanks!

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@tungld
Copy link
Collaborator

tungld commented May 15, 2025

@jenkins-droid test this please

Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowering BitwiseNot Op to the Krnl Dialect
4 participants