-
Notifications
You must be signed in to change notification settings - Fork 346
added support for bitwise_not op #3156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a complete contribution!
test/mlir/conversion/onnx_to_krnl/Math/Elementwise_with_canonicalize_O3.mlir
Outdated
Show resolved
Hide resolved
@LekkalaSravya3 when you create a commit, please sign it by |
53e05a1
to
75b0391
Compare
Can one of the admins verify this patch? |
75b0391
to
bc5feec
Compare
Can one of the admins verify this patch? |
e79a969
to
6db553a
Compare
Can one of the admins verify this patch? |
@jenkins-droid test this please |
Can one of the admins verify this patch? |
I see this error. Looks related to the name of the test
you can run the tests using |
Can one of the admins verify this patch? |
Signed-off-by: LekkalaSravya3 <[email protected]>
Signed-off-by: LekkalaSravya3 <[email protected]>
Signed-off-by: LekkalaSravya3 <[email protected]>
de68012
to
51e4fba
Compare
Can one of the admins verify this patch? |
Signed-off-by: LekkalaSravya3 <[email protected]>
51e4fba
to
1f05624
Compare
Can one of the admins verify this patch? |
Thanks! I've updated it and confirmed that the test passes using make check-onnx-backend . |
Signed-off-by: LekkalaSravya3 <[email protected]>
950162c
to
a868ba3
Compare
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LekkalaSravya3 thank you for the update! It's almost done. Just two small comments. Please make the changes. Thanks!
test/mlir/conversion/onnx_to_krnl/Math/Elementwise_with_canonicalize_O3.mlir
Outdated
Show resolved
Hide resolved
Signed-off-by: LekkalaSravya3 <[email protected]>
Can one of the admins verify this patch? |
@jenkins-droid test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Added support for the BitwiseNot operation in the ONNX to Krnl lowering path. Also included corresponding test cases in Elementwise_with_canonicalize.mlir and Elementwise_with_canonicalize_O3.mlir. This implementation addresses and
closes #3155