-
Notifications
You must be signed in to change notification settings - Fork 346
Add Lowering of ThresholdedRelu op from ONNX to Krnl Dialect #3154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Lowering of ThresholdedRelu op from ONNX to Krnl Dialect #3154
Conversation
4b2b561
to
2cd4f59
Compare
Can one of the admins verify this patch? |
2cd4f59
to
fa3c1e7
Compare
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will approve once it run the CIs. Please also check if the minimum opset should not be reduced. Left a comment about this.
Thanks for the good work, you followed past template well and this PR is very complete
@jenkins-droid test this please |
fa3c1e7
to
b870861
Compare
Can one of the admins verify this patch? |
b870861
to
ed0cb66
Compare
Can one of the admins verify this patch? |
Signed-off-by: Vishali Senthilkumar <[email protected]>
fe0225a
to
95ea07f
Compare
Can one of the admins verify this patch? |
This pull request implements the lowering of the
ThresholdedRelu
op from the ONNX dialect to the Krnl dialect, and add tests to validate it, addressing Issue #3151.This PR is ready for review. Please let me know if there are any additional improvements or adjustments needed.
Closes #3151.