Skip to content

Add Lowering of ThresholdedRelu op from ONNX to Krnl Dialect #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

VishaliSenthilkumar
Copy link

This pull request implements the lowering of the ThresholdedRelu op from the ONNX dialect to the Krnl dialect, and add tests to validate it, addressing Issue #3151.

This PR is ready for review. Please let me know if there are any additional improvements or adjustments needed.

Closes #3151.

@VishaliSenthilkumar VishaliSenthilkumar force-pushed the add-thresholdedrelu-support branch from 4b2b561 to 2cd4f59 Compare May 12, 2025 14:03
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@VishaliSenthilkumar VishaliSenthilkumar force-pushed the add-thresholdedrelu-support branch from 2cd4f59 to fa3c1e7 Compare May 12, 2025 14:09
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will approve once it run the CIs. Please also check if the minimum opset should not be reduced. Left a comment about this.

Thanks for the good work, you followed past template well and this PR is very complete

@AlexandreEichenberger
Copy link
Collaborator

@jenkins-droid test this please

@VishaliSenthilkumar VishaliSenthilkumar force-pushed the add-thresholdedrelu-support branch from fa3c1e7 to b870861 Compare May 13, 2025 05:33
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@VishaliSenthilkumar VishaliSenthilkumar force-pushed the add-thresholdedrelu-support branch from b870861 to ed0cb66 Compare May 13, 2025 05:35
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@VishaliSenthilkumar VishaliSenthilkumar force-pushed the add-thresholdedrelu-support branch from fe0225a to 95ea07f Compare May 14, 2025 06:56
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for ThresholdedRelu in Krnl Dialect
3 participants