Skip to content

LLVM update 43d71ba #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 68 commits into
base: main
Choose a base branch
from
Open

LLVM update 43d71ba #3086

wants to merge 68 commits into from

Conversation

brnorris03
Copy link
Collaborator

@brnorris03 brnorris03 commented Feb 21, 2025 •
edited
Loading

@brnorris03 brnorris03 changed the title Llvm update 0e779ad LLVM update 0e779ad Feb 21, 2025
@brnorris03
Copy link
Collaborator Author

@AlexandreEichenberger -- this seems like a rather large update, so I could use some help. There were a lot of TOSA dialect changes, and I am going through lit tests now and updating them (no problems there so far) -- should be done today hopefully. The check-onnx-numerical also passes.

However, most of the backend tests fail, e.g., in the check-onnx-backend-constant, and I am not sure what the best way is to investigate these failures.

@brnorris03
update float types, tosa, other misc changes
85adea4 
Signed-off-by: Boyana Norris <[email protected]>
@brnorris03
fix buildOnnxToTosaPaddingConstOp
575843d 
Signed-off-by: Boyana Norris <[email protected]>
@brnorris03
fix lit tests (wip)
4b8bc70 
Signed-off-by: Boyana Norris <[email protected]>
@brnorris03
updte doc
7015679 
Signed-off-by: Boyana Norris <[email protected]>
@brnorris03
use stablehlo tagged version
65ff3c0 
Signed-off-by: Boyana Norris <[email protected]>
@brnorris03
fixed more lit tests
685c3f5 
Signed-off-by: Boyana Norris <[email protected]>
@brnorris03
fix .clang-format
fa9186e 
Signed-off-by: Boyana Norris <[email protected]>
@brnorris03
fix lit (wip)
09ca5c1 
Signed-off-by: Boyana Norris <[email protected]>
@AlexandreEichenberger
Copy link
Collaborator

@jorickert thanks for helping with the TOSA related updates.
@brnorris03 if you feel that there are issues that are not TOSA related and you need further help, I am back at work and would be happy to help.

@brnorris03
Copy link
Collaborator Author

@jorickert thanks for helping with the TOSA related updates. @brnorris03 if you feel that there are issues that are not TOSA related and you need further help, I am back at work and would be happy to help.

Thanks! I did have everything passing locally, but the stablehlo build failed CI. So I updated the llvm and stablehlo versions again, which brought in another pile of TOSA changes; everything builds but I have not had a chance to update all the lit tests yet.

@brnorris03 brnorris03 changed the title LLVM update 0e779ad LLVM update 43d71ba Mar 3, 2025
@Sunny-Anand
Copy link
Collaborator

@brnorris03 we are creating a new release for onnx-mlir, 0.5.0 and would like to hold off on the llvm-stablehlo upgrade for now. FYI @AlexandreEichenberger

@brnorris03
Copy link
Collaborator Author

@brnorris03 we are creating a new release for onnx-mlir, 0.5.0 and would like to hold off on the llvm-stablehlo upgrade for now. FYI @AlexandreEichenberger

What does that mean exactly? Wait and rebase later? Or close this and let someone else redo later? It's a huge update because of the TOSA changes, so I am probably not going to have time to do another one from scratch.

@Sunny-Anand
Copy link
Collaborator

@brnorris03 Yeah, let's wait and attempt to merge into the main after 0.5.0 is created, I expect it to be in the next 1-2 weeks. Hopefully that will not block this pr.

@Sunny-Anand
Copy link
Collaborator

@brnorris03 0.5.0 branch is created. Pls feel free to merge this pr now into main if done. Thanks for your patience.

jorickert and others added 17 commits May 9, 2025 00:44
@jorickert @tungld
Change tosaBuilder::mul function signature to make clear that the shi…
2acd812 
…ft is an int8

Signed-off-by: Rickert, Jonas <[email protected]>
@jorickert @tungld
Disable buffer_loop_hoisting test as it gets completly optimized away
1357f0b 
Signed-off-by: Rickert, Jonas <[email protected]>
@jorickert @tungld
Guard against dynamic dim in result
20a1cf7 
Signed-off-by: Rickert, Jonas <[email protected]>
@jorickert @tungld
Use resize operaton input and output type to calculate the border, in…
5bc4937 
…stead of using the calculated numerator/denominator

Signed-off-by: Rickert, Jonas <[email protected]>
@jorickert @tungld
Guard against linear interpolation of integer types
3b21c0a 
Signed-off-by: Rickert, Jonas <[email protected]>
@jorickert @tungld
Add test for disallowed onnx.Resize on its with linear interpolation …
319933a 
…to tosa

Signed-off-by: Rickert, Jonas <[email protected]>
@jorickert @tungld
Add 'Pure' annotation to some krnl ops and recreate documentation
a1e584d 
Signed-off-by: Rickert, Jonas <[email protected]>
@jorickert @tungld
Build stablehlo with static libs
3fbc8f8 
Signed-off-by: Rickert, Jonas <[email protected]>
@tungld
Disable memref.prefetch since it does not work with the new bufferiza…
5627762 
…tion

Signed-off-by: Tung D. Le <[email protected]>
@AlexandreEichenberger @tungld
Conv add const where the constant is a scalar (onnx#3145)
51897ad 
Signed-off-by: Alexandre Eichenberger <[email protected]>
@logeshwaranmcw @AlexandreEichenberger @tungld
added support for Celu op (onnx#3139)
55251a0 
Signed-off-by: logeshwaranmcw <[email protected]>
Co-authored-by: Alexandre Eichenberger <[email protected]>
@tungld
Fix some warnings related to stickification for NNPA (onnx#3147)
7a5c8e0 
Signed-off-by: Tung D. Le <[email protected]>
@christopherlmunoz @tungld
Removing duplicate file (onnx#3146)
35f73c0 
Signed-off-by: Christopher Munoz <[email protected]>
@AlexandreEichenberger @tungld
migrated instance/group normalization from decompose to canonicalize (o…
a0ff012 
…nnx#3148)

Signed-off-by: Alexandre Eichenberger <[email protected]>
@AlexandreEichenberger @tungld
Fusion of Matmul add covering the stacked/unstacked/bcast1/bcast23 pa…
6faf742 
…tterns (onnx#3140)

Signed-off-by: Alexandre Eichenberger <[email protected]>
@chentong319 @tungld
Support --march=native (onnx#3134)
7a621c3 
* changes

Signed-off-by: Chen Tong <[email protected]>

* format

Signed-off-by: Chen Tong <[email protected]>

* linkage

Signed-off-by: Chen Tong <[email protected]>

* lib

Signed-off-by: Chen Tong <[email protected]>

---------

Signed-off-by: Chen Tong <[email protected]>
@tungld
fix another error on s390x
0c5b71b 
Signed-off-by: Tung D. Le <[email protected]>
@tungld tungld force-pushed the llvm-update-0e779ad branch from a656f29 to 0c5b71b Compare May 9, 2025 04:46
@tungld
Copy link
Collaborator

tungld commented May 9, 2025

@jorickert I fixed some errors on Jenkins Linux s390x.

I also attempted to fix the DCO issue due to some commits not being signed off, but I haven't succeeded yet. If you know how to resolve this, please do so. Otherwise, we may need to force it to pass by pressing the 'Set DCO Pass' button.

tungld
tungld approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tungld tungld marked this pull request as ready for review May 9, 2025 08:22
@jorickert
Copy link
Collaborator

@tungld Thanks for making this work on s390x.

Regarding the DCO check. According to the instructions in https://hackmd.io/@James-Ebert/HyYOcRAXo it is possible to update them via rebase, but as multiple commits have wrong/missing signoff this could be a bit difficult (and I'm not really comfortable with adjusting the Signoff of commits that are not from me).

@AlexandreEichenberger
Copy link
Collaborator

Let me know if its ready to merge @jorickert

jorickert
jorickert approved these changes May 9, 2025
View reviewed changes
Copy link
Collaborator

@jorickert jorickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks to everyone helping with this bump

@AlexandreEichenberger
Copy link
Collaborator

@brnorris03 are you fine with this PR being merged?

@jorickert jorickert mentioned this pull request May 14, 2025
Closed
@jorickert
Copy link
Collaborator

@brnorris03 Could you please take a look if this PR is fine for you, so we can merge it? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tungld tungld tungld approved these changes

@jorickert jorickert jorickert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.