Skip to content

Recompose multiple ops into a single ONNXGelu #2965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 4, 2024

Conversation

tungld
Copy link
Collaborator

@tungld tungld commented Oct 4, 2024

This patch recomposes multiple operations into a single ONNXGelu operation.

tungld added 6 commits October 3, 2024 05:27
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
@tungld tungld changed the title Recompose gelu Recompose multiple ops into a single ONNXGelu Oct 4, 2024
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for expanding the usage of the matchValueAndOp in such a meaningful way. Really make the matching code more readable.

@tungld tungld merged commit 7c58751 into onnx:main Oct 4, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15783 [push] Recompose multiple ops i... started at 09:22

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15786 [push] Recompose multiple ops i... started at 10:22

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14813 [push] Recompose multiple ops i... started at 10:34

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15783 [push] Recompose multiple ops i... passed after 1 hr 20 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15786 [push] Recompose multiple ops i... aborted after 1 hr 49 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14813 [push] Recompose multiple ops i... aborted after 1 hr 50 min

@hamptonm1
Copy link
Collaborator

@tungld I know this was merged already but still wanted to review. Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants