-
Notifications
You must be signed in to change notification settings - Fork 347
Recompose multiple ops into a single ONNXGelu #2965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Tung D. Le <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for expanding the usage of the matchValueAndOp
in such a meaningful way. Really make the matching code more readable.
Jenkins Linux amd64 Build #15783 [push] Recompose multiple ops i... started at 09:22 |
Jenkins Linux s390x Build #15786 [push] Recompose multiple ops i... started at 10:22 |
Jenkins Linux ppc64le Build #14813 [push] Recompose multiple ops i... started at 10:34 |
Jenkins Linux amd64 Build #15783 [push] Recompose multiple ops i... passed after 1 hr 20 min |
Jenkins Linux s390x Build #15786 [push] Recompose multiple ops i... aborted after 1 hr 49 min |
Jenkins Linux ppc64le Build #14813 [push] Recompose multiple ops i... aborted after 1 hr 50 min |
@tungld I know this was merged already but still wanted to review. Looks good to me! |
This patch recomposes multiple operations into a single ONNXGelu operation.