Skip to content

Minor updates to CompilerUtils.cpp #2958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

gongsu832
Copy link
Collaborator

  • print javaruntime.jar path when -v (verbose) is specified for debugging aid
  • replace printf with llvm::outs() for consistency
  • fix typo ouputNameWithExt

  debugging aid
- replace printf with llvm::outs() for consistency
- fix typo ouputNameWithExt

Signed-off-by: Gong Su <[email protected]>
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@gongsu832 gongsu832 merged commit e5901e2 into onnx:main Sep 29, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15728 [push] - print javaruntime.jar ... started at 13:01

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14755 [push] - print javaruntime.jar ... started at 13:13

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15725 [push] - print javaruntime.jar ... started at 12:01

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15725 [push] - print javaruntime.jar ... passed after 1 hr 13 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15728 [push] - print javaruntime.jar ... passed after 1 hr 35 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14755 [push] - print javaruntime.jar ... passed after 2 hr 20 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants