Skip to content

Change c style cast to c++ style cast #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Change c style cast to c++ style cast #2936

merged 1 commit into from
Sep 10, 2024

Conversation

mikeessen
Copy link
Contributor

This PR updates c style casts to c++ style.

Signed-off-by: Mike Essenmacher <[email protected]>
Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Mike

@mikeessen mikeessen merged commit 8dc51ac into onnx:main Sep 10, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14595 [push] Change c style cast to c... started at 13:45

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15569 [push] Change c style cast to c... started at 13:35

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15566 [push] Change c style cast to c... started at 12:36

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15566 [push] Change c style cast to c... passed after 1 hr 8 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15569 [push] Change c style cast to c... passed after 2 hr 0 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14595 [push] Change c style cast to c... aborted after 2 hr 3 min

Sunny-Anand pushed a commit to Sunny-Anand/onnx-mlir that referenced this pull request Sep 17, 2024
Signed-off-by: Mike Essenmacher <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>
Sunny-Anand added a commit that referenced this pull request Sep 17, 2024
* Change lowering of onnx.IF to Krnl (#2932)

* implementation

Signed-off-by: chentong319 <[email protected]>

* test case change

Signed-off-by: chentong319 <[email protected]>

* format

Signed-off-by: chentong319 <[email protected]>

* add test for If back

Signed-off-by: chentong319 <[email protected]>

* format

Signed-off-by: chentong319 <[email protected]>

---------

Signed-off-by: chentong319 <[email protected]>
Co-authored-by: Tung D. Le <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* Update c style cast to c++ style cast (#2934)

Signed-off-by: Mike Essenmacher <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* Change c style cast to c++ style cast (#2936)

Signed-off-by: Mike Essenmacher <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* Add coding practices for onnx-mlir (#2935)

Signed-off-by: Mike Essenmacher <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* try to use new buffer deallocation (#2919)

* implementation

Signed-off-by: Chen Tong <[email protected]>

* comments

Signed-off-by: Chen Tong <[email protected]>

* format

Signed-off-by: Chen Tong <[email protected]>

---------

Signed-off-by: Chen Tong <[email protected]>
Co-authored-by: Tung D. Le <[email protected]>
Co-authored-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* fix requirements.txt link

Signed-off-by: Sunny-Anand <[email protected]>

* Reuse input buffer in lowering to krnl (#2939)

* first step

Signed-off-by: chentong319 <[email protected]>

* cpu

Signed-off-by: chentong319 <[email protected]>

* options

Signed-off-by: chentong319 <[email protected]>

* unify

Signed-off-by: chentong319 <[email protected]>

* simd

Signed-off-by: chentong319 <[email protected]>

* comments

Signed-off-by: chentong319 <[email protected]>

* lit test

Signed-off-by: chentong319 <[email protected]>

* fix test

Signed-off-by: chentong319 <[email protected]>

* format

Signed-off-by: chentong319 <[email protected]>

* response

Signed-off-by: chentong319 <[email protected]>

---------

Signed-off-by: chentong319 <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* Fix GroupNorm to support Opset21 (#2928)

* Group norm for opset 21

* Testing phase

* Fix GroupNorm to support Opset21

---------

Signed-off-by: hamptonm1 <[email protected]>
Co-authored-by: Megan Hampton <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* Update Ops documentation for ONNX 1.16.2 (#2942)

* Update Ops documentation for ONNX 1.16.2

* Fix format

---------

Co-authored-by: Megan Hampton <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* LLVM/StableHLO Upgrade eaa95a1 (#2943)

Co-authored-by: Megan Hampton <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* added support for no-zero-point quantization (#2938)

Signed-off-by: Alexandre Eichenberger <[email protected]>
Co-authored-by: Tung D. Le <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>

* update with main

Signed-off-by: Sunny-Anand <[email protected]>

---------

Signed-off-by: chentong319 <[email protected]>
Signed-off-by: Sunny-Anand <[email protected]>
Signed-off-by: Mike Essenmacher <[email protected]>
Signed-off-by: Chen Tong <[email protected]>
Signed-off-by: hamptonm1 <[email protected]>
Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Sunny Anand <[email protected]>
Co-authored-by: Tong Chen <[email protected]>
Co-authored-by: Tung D. Le <[email protected]>
Co-authored-by: Mike Essenmacher <[email protected]>
Co-authored-by: Alexandre Eichenberger <[email protected]>
Co-authored-by: hamptonm1 <[email protected]>
Co-authored-by: Megan Hampton <[email protected]>
@mikeessen mikeessen deleted the essen-updates branch October 3, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants