Skip to content

Softmax op dynamic shape addition for stablehlo #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Abhishek-TyRnT
Copy link
Contributor

Added support for dynamic shapes in Softmax Op for StableHLO Dialect

@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@Abhishek-TyRnT Abhishek-TyRnT force-pushed the softmax-op-dynamic-shape-addition-for-stablehlo branch from 9a4e95e to c6ca978 Compare August 26, 2024 14:26
@jenkins-droid
Copy link
Collaborator

Can one of the admins verify this patch?

@AlexandreEichenberger
Copy link
Collaborator

@jenkins-droid test this please

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me update to the latest version and I can then approve it.

@AlexandreEichenberger
Copy link
Collaborator

@Abhishek-TyRnT do you want me to merge it?

@Abhishek-TyRnT
Copy link
Contributor Author

@AlexandreEichenberger Yes, please go ahead and merge it

Copy link
Collaborator

@AlexandreEichenberger AlexandreEichenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexandreEichenberger AlexandreEichenberger merged commit 4f0a141 into onnx:main Aug 27, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15450 [push] Softmax op dynamic shape... started at 17:35

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15457 [push] Softmax op dynamic shape... started at 18:35

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14480 [push] Softmax op dynamic shape... started at 18:46

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15450 [push] Softmax op dynamic shape... passed after 1 hr 6 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15457 [push] Softmax op dynamic shape... passed after 1 hr 26 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14480 [push] Softmax op dynamic shape... passed after 1 hr 57 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants