Skip to content

Added file name and time elapsed to onnx-mlir messages #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlexandreEichenberger
Copy link
Collaborator

We already printed the "time of day", found it useful to also add the elapsed time.
In addition, when running our backend tests, it is sometime convenient to know which benchmark crashes... so adding the file name to the first message is useful.

> onnx-mlir roberta-base-11.onnx -enable-timing -O3 -march=arm64
[1/6] Wed Aug 21 11:48:07 2024 (0s) Importing ONNX Model to MLIR Module from "roberta-base-11.onnx"
[2/6] Wed Aug 21 11:48:07 2024 (0s) Compiling and Optimizing MLIR Module
[3/6] Wed Aug 21 11:48:09 2024 (2s) Translating MLIR Module to LLVM and Generating LLVM Optimized Bitcode
[4/6] Wed Aug 21 11:48:55 2024 (48s) Generating Object from LLVM Bitcode
[5/6] Wed Aug 21 11:49:15 2024 (68s) Linking and Generating the Output Shared Library
[6/6] Wed Aug 21 11:49:15 2024 (68s) Compilation completed

Signed-off-by: Alexandre Eichenberger <[email protected]>
Copy link
Collaborator

@chentong319 chentong319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Alexandre Eichenberger <[email protected]>
@AlexandreEichenberger AlexandreEichenberger merged commit ad885ed into onnx:main Aug 22, 2024
7 checks passed
@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15423 [push] Added file name and time... started at 16:24

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15430 [push] Added file name and time... started at 17:24

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14453 [push] Added file name and time... started at 17:33

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #15423 [push] Added file name and time... passed after 1 hr 6 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #15430 [push] Added file name and time... passed after 1 hr 29 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #14453 [push] Added file name and time... passed after 2 hr 0 min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants