Update macro parameter names with parentheses

[mikeessen]

Update code to add macro parameter names with parentheses to zDNNExtension and Stickify.

[AlexandreEichenberger]

Grepping for #define *[\w_-]* *\( I find more patterns

e.g.

#define OM_TYPE_METADATA_DEF(ENUM_NAME, ENUM_VAL, DTYPE_SIZE, DTYPE_NAME)      \
  ENUM_NAME = ENUM_VAL,

or

#define INVOKE_ACCEL_INIT_FUNCTION(name, kinds)                                \
  if (!kinds.empty() &&                                                        \
      llvm::is_contained(kinds, accel::Accelerator::Kind::name))               \
    create##name()->setName(#name);

#define compareFunctionBody(typeName, direction, load, dataPtr, idx1p, idx2p)  \
  {                                                                            \
    uint64_t idx1 = *((uint64_t *)idx1p);                                      \
    uint64_t idx2 = *((uint64_t *)idx2p);                                      \
    typeName *data = (typeName *)dataPtr;                                      \
    load(typeName, v1, data[idx1]);                                            \
    load(typeName, v2, data[idx2]);                                            \
    return (direction(v1, v2) || (v1 == v2 && idx1 < idx2)) ? -1 : 1;          \
  }

and many more in that file

#define LOOP_1(INDEX, IV, UB)                                                  \
  fprintf(fout, "[");                                                          \
  for (int64_t IV = 0; IV < UB; ++IV) {                                        \
    if (IV)                                                                    \
      fprintf(fout, ", ");                                                     \
    indexes[INDEX] = IV;                                                       \
    int64_t elemOffset = computeElemOffset(tensor->_strides, indexes, rank);   \
    printElement(fout, dataPtr, elemOffset, dataType);                         \
  }                                                                            \
  fprintf(fout, "]");

and many more in that file

#define THREAD_LOCAL_INIT(key, func) pthread_once(key, func)

#define MIN(x, y) ((x) > (y) ? y : x)

and many more in that file

#define CHECK_CALL(type, var, call, success, ...)                              \
  type var = call;                                                             \
  do {                                                                         \
    if (!(success)) {                                                          \
      LOG_PRINTF(LOG_ERROR, __VA_ARGS__);                                      \
      return NULL;                                                             \
    }                                                                          \
  } while (0)

and many more in that file

#define BIT_CAST(TO_TYPE, TO, FROM)                                            \
  TO_TYPE TO;                                                                  \
  static_assert(sizeof(TO) == sizeof(FROM), "only bit cast same sizes");       \
  memcpy(&TO, &FROM, sizeof(FROM))

and more in that file

#define IGNORE_ARG(FLAG)                                                       \
  if (arg.find(FLAG) == 0) {                                                   \
    return false;                                                              \
  }

plus more in that file

[mikeessen]

@AlexandreEichenberger Thanks for the comment! I added more updates.

[AlexandreEichenberger]

LGTM, thanks for looking at all these other patterns

[jenkins-droid]

Jenkins Linux s390x Build #15411 [push] Update macro parameter n... started at 07:15

[jenkins-droid]

Jenkins Linux ppc64le Build #14436 [push] Update macro parameter n... started at 07:24

[jenkins-droid]

Jenkins Linux amd64 Build #15406 [push] Update macro parameter n... started at 06:15

[jenkins-droid]

Jenkins Linux amd64 Build #15406 [push] Update macro parameter n... passed after 1 hr 7 min

[jenkins-droid]

Jenkins Linux s390x Build #15411 [push] Update macro parameter n... passed after 1 hr 31 min

[jenkins-droid]

Jenkins Linux ppc64le Build #14436 [push] Update macro parameter n... passed after 2 hr 8 min