Cleanup HeapReporter command line options #2783
Merged
+29
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: philass <[email protected]>
sorenlassen
approved these changes
Apr 4, 2024
src/Compiler/HeapReporter.cpp
Outdated
| reportBegin("onnx-mlir heap report" | ||
| "\n--report-heap-before='" + | ||
| beforePasses.str() + "'\n--report-heap-after='" + | ||
| afterPasses.str() + "'"); | ||
| beforePassesStr + "'\n--report-heap-after=" + afterPassesStr); |
There was a problem hiding this comment.
can you use llvm::join() from StringExtras.h?
llvm::join(beforePasses, ",") + "'\n--report-heap-after=" + llvm::join(afterPasses, ",")
There was a problem hiding this comment.
I knew there must be some handy function for this lying around. Thanks for the pointer
Signed-off-by: philass <[email protected]>
philass
force-pushed
the
plassen/heap-option-cleanup
branch
from
27996f4 to
582c3b8
Compare
|
Jenkins Linux ppc64le Build #13632 [push] Cleanup HeapReporter com... started at 22:17 |
|
Jenkins Linux s390x Build #14637 [push] Cleanup HeapReporter com... started at 22:07 |
|
Jenkins Linux amd64 Build #14607 [push] Cleanup HeapReporter com... started at 21:07 |
|
Jenkins Linux amd64 Build #14607 [push] Cleanup HeapReporter com... passed after 1 hr 16 min |
|
Jenkins Linux s390x Build #14637 [push] Cleanup HeapReporter com... passed after 1 hr 32 min |
|
Jenkins Linux ppc64le Build #13632 [push] Cleanup HeapReporter com... passed after 1 hr 55 min |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
llvm::cl::listto handle the parsing of a list of passes past as command line options.This is consistent with the
onnx-const-prop-disable-patternandfunctions-to-decomposeimplementations for list command line parsing.