Fix autowiring

[toooni]

Autowiring doesn't work for me without autowire: true in services.yml and using the Container as typehint doesn result in the following message:

Cannot autowire service "ONGR\ElasticsearchBundle\Command\CacheClearCommand": argument "$container" of method "ONGR\ElasticsearchBundle\Command\AbstractIndexServiceAwareCommand::__construct()" references class "Symfony\Component\DependencyInject
ion\Container" but no such service exists. Try changing the type-hint to one of its parents: interface "Psr\Container\ContainerInterface", or interface "Symfony\Component\DependencyInjection\ContainerInterface".

[toooni]

Travis-ci was failing because of an unrelated while trying to download something, so I re-pushed the branch.

[codecov-io]

Codecov Report

Merging #913 into 7.0 will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##                7.0     #913   +/-   ##
=========================================
  Coverage     83.16%   83.16%           
  Complexity      413      413           
=========================================
  Files            39       39           
  Lines          1360     1360           
=========================================
  Hits           1131     1131           
  Misses          229      229

Impacted Files	Coverage Δ	Complexity Δ
Command/AbstractIndexServiceAwareCommand.php	100% <100%> (ø)	6 <2> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a6398...4122bbe. Read the comment docs.

[patie]

can you please fix also for v6 bundle and symfony 4.4? thanks!

In AbstractIndexServiceAwareCommand.php line 27:

  Too few arguments to function ONGR\ElasticsearchBundle\Command\AbstractIndexServiceAwareCommand::__construct(), 0 passed in /home/www/xxx/
  home/patie/subdomains/nw-api/var/cache/dev/Container6RY9hyi/getCacheClearCommandService.php on line 13 and exactly 1 expected


In AbstractIndexServiceAwareCommand.php line 27:

  Too few arguments to function ONGR\ElasticsearchBundle\Command\AbstractIndexServiceAwareCommand::__construct(), 0 passed in /home/www/xxx/
  home/patie/subdomains/nw-api/var/cache/dev/Container6RY9hyi/getIndexCreateCommandService.php on line 13 and exactly 1 expected


In AbstractIndexServiceAwareCommand.php line 27:

  Too few arguments to function ONGR\ElasticsearchBundle\Command\AbstractIndexServiceAwareCommand::__construct(), 0 passed in /home/www/xxx/
  home/patie/subdomains/nw-api/var/cache/dev/Container6RY9hyi/getIndexDropCommandService.php on line 13 and exactly 1 expected


In AbstractIndexServiceAwareCommand.php line 27:

  Too few arguments to function ONGR\ElasticsearchBundle\Command\AbstractIndexServiceAwareCommand::__construct(), 0 passed in /home/www/xxx/
  home/patie/subdomains/nw-api/var/cache/dev/Container6RY9hyi/getIndexExportCommandService.php on line 13 and exactly 1 expected


In AbstractIndexServiceAwareCommand.php line 27:

  Too few arguments to function ONGR\ElasticsearchBundle\Command\AbstractIndexServiceAwareCommand::__construct(), 0 passed in /home/www/xxx/
  home/patie/subdomains/nw-api/var/cache/dev/Container6RY9hyi/getIndexImportCommandService.php on line 13 and exactly 1 expected

[toooni]

@patie It would have been easy for you to create a PR with e cherry-pick from the 7.0 fix. It took me like a minute for #915. You're welcome.

[saimaz]

Didn't notice it is also a problem for v6, will cherry-pick it with the next release of v6

[toooni]

@saimaz I already made the PR 👍

[patie]

@toooni @saimaz its wierd, i have still the same problem with too few arguments in AbstractIndexServiceAwareCommand in ~6.2 and Sf4.4, any idea please? thanks

[saimaz]

It's not released yet. I will release it in the evening.

[patie]

dont work even with 6.2.x-dev#04d452a, but maybe you need do more, i will wait till tommorow, thanks for bundle

EDIT: and the same problem is with version 7 with Symfony 4.4

[toooni]

@patie clearing the cache might not be enough. Delete the symfony cache/dev folder.

[patie]

deleted but dont work anyway, now do refactor on our project for upgrade to sf5