A small upgrade to the v6 #868
Conversation
| /** | ||
| * Index alias name. By default the index name will be created with the timestamp appended to the alias. | ||
| */ | ||
| public $hosts = [ |
There was a problem hiding this comment.
@saimaz Is this a good idea? Its not possible to use environment variables or parameters inside annotation or? same for numberOfShards, ... this is system specific
There was a problem hiding this comment.
There will be a config which can override index settings. The annotation settings were added to make things more simple. In that case, you won't need any config when someone uses default settings (like the host is 127.0.0.1:9200 and the index alias name is like the class name).
There was a problem hiding this comment.
Ah ok, sounds good.
PS: the comment above $hosts looks false.
There was a problem hiding this comment.
This is why it is still a beta stage :) But if you could test this version and give some feedback I would appreciate it a lot.
There was a problem hiding this comment.
I will try to test the version at end of the week.
There was a problem hiding this comment.
At the end of the week, there will be docs written as well I think.
| $response = []; | ||
|
|
||
| // %X is not very accurate, but better than use counter. This place is experimental for now. | ||
| if ($autoCommit && $this->getBulkCommitSize() <= count($this->bulkQueries) % $this->getBulkCommitSize() / 2) { |
There was a problem hiding this comment.
This will always return false.
Say bulkCommitSize is 100, count($this->bulkQueries) % $this->getBulkCommitSize() / 2 will always return a float between 0 and 49,5 which is always lower then bulkCommitSize 100
No description provided.