Skip to content

Restrict compatible PHP versions to currently supported ones #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

YetiCGN
Copy link
Contributor

@YetiCGN YetiCGN commented Nov 15, 2018

We haven't tested PHP 7.3, 7.4, 8.0 or 9.0 yet, so we shouldn't claim compatibility with every version greater than or equal to PHP 5.6.

@saimaz
Copy link
Contributor

saimaz commented Nov 16, 2018

Agree. In that case we will avoid the future conflicts. Thanks for the notice.

@saimaz saimaz merged commit 7aa6fb3 into ongr-io:5.2 Nov 16, 2018
@YetiCGN YetiCGN deleted the feature/php-version-constraint branch November 19, 2018 15:46
@YetiCGN
Copy link
Contributor Author

YetiCGN commented Nov 19, 2018

Thanks!

What about a merge to master? Is that a good idea? If so, should I open another PR or will you change it?

@saimaz
Copy link
Contributor

saimaz commented Nov 19, 2018

I will merge it to the master later. If you want to introduce any new change as a PR you should start from the branch as in the version you are targeting to release.

@HcErwin
Copy link

HcErwin commented Dec 5, 2019

I'm running v5.2.* for a while now on 7.4 locally and works great. Due to the restriction I can't update my test/staging server through my pipelines (can't hack like locally). Maybe we can unlock 7.4?

@YetiCGN
Copy link
Contributor Author

YetiCGN commented Dec 5, 2019

@HcErwin 6.0.* supports PHP 7.4, can you upgrade to the next major version?

@HcErwin
Copy link

HcErwin commented Dec 5, 2019

Sadly no, because our platform is quite big and is still locked to Elastic 5.*. Otherwise I would've certainly upgraded, but still discussing the upgrade to 6 or 7 for now :)

@YetiCGN
Copy link
Contributor Author

YetiCGN commented Dec 5, 2019

Then you could fork the repository and change the restriction in the ElasticsearchBundle composer.json, commit and push to your fork's branch and include that as a repository in your project's composer.json like this:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/HcErwin/ElasticsearchBundle"
        }
    ],

@HcErwin
Copy link

HcErwin commented Dec 5, 2019

That sounds the most logical for now indeed; thank you! :D

@patie
Copy link

patie commented Jan 16, 2022

can u please add support for PHP8? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants