Skip to content

Respect config values for evm & vm bridge setup #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Jun 20, 2025

Description

The default values for SetupEVMEnabled & SetupVMBridgeEnabled are true.
However, if for whatever reason, someone tries to set false for these two, it isn't possible to do so.
Because the option is only appended when conf.SetupEVMEnabled & conf.SetupVMBridgeEnabled are set to true.


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@bluesign
Copy link
Collaborator

bluesign commented Jun 20, 2025

I think also need to sanitize those; conf.SetupEVMEnabled = False & conf.SetupVMBridgeEnabled = True does not seem to be a valid case.

PS: I recall seeing some issue or comment, saying EVM disabled is not a valid case anymore somewhere.
found it: onflow/flow-go#7507

Maybe removing EVMEnabled flag, and just keeping Bridge flag makes sense, what do you think @m-Peter ?

@m-Peter m-Peter force-pushed the mpeter/fix-vm-bridge-setup branch from e32f688 to 5fb1ba0 Compare June 20, 2025 10:02
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.45%. Comparing base (96c4f80) to head (4e2f7bc).
Report is 86 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   35.30%   34.45%   -0.85%     
==========================================
  Files          47       45       -2     
  Lines        7418     7345      -73     
==========================================
- Hits         2619     2531      -88     
- Misses       4610     4632      +22     
+ Partials      189      182       -7     
Flag Coverage Δ
unittests 34.45% <100.00%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-Peter
Copy link
Collaborator Author

m-Peter commented Jun 20, 2025

@bluesign You are indeed right 💯

I was merely trying to solve a bug in the first place, to fix the CI for onflow/flow-evm-gateway#832 .
I haven't followed along on these VM Bridge changes, so I'll wait for @jribbink to jump in, as he may have more context on how to properly proceed with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants