Skip to content

refactor(cli): use flags and add version #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

refactor(cli): use flags and add version #501

merged 1 commit into from
Mar 5, 2024

Conversation

corverroos
Copy link
Collaborator

@corverroos corverroos commented Mar 5, 2024 •
edited
Loading

Improve omni cli:

  • Use ohly flags (not positional args)
  • Add a omni version command

Adds buildinfo.Version:

  • Global omni version
  • Set version via goreleaser at release time (equaled to git tag)
  • Adds a metric for version, also log it with other build infos (git commit).
  • Add a <app> version subcommand to halo,relayer,omnicli.

Also:

  • Remove e2e/netman/avs since it is replaced with lib/avs.

task: none

@corverroos corverroos force-pushed the corver/cliclean branch 2 times, most recently from 6430b01 to 5814f5d Compare March 5, 2024 09:49
idea404
idea404 approved these changes Mar 5, 2024
View reviewed changes
lib/avs/avs_test.go
ConfigFile: configFile,
AVSAddr: contracts.OmniAVSAddr.Hex(),
}
err = clicmd.Register(ctx, regCfg, testOpts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@corverroos corverroos merged commit 3587b42 into main Mar 5, 2024
@corverroos corverroos deleted the corver/cliclean branch March 5, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idea404 idea404 idea404 approved these changes

@Lazar955 Lazar955 Lazar955 approved these changes

@pavelnikolov pavelnikolov Awaiting requested review from pavelnikolov

@kevinhalliday kevinhalliday Awaiting requested review from kevinhalliday kevinhalliday is a code owner

@DanFlannel DanFlannel Awaiting requested review from DanFlannel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corverroos @idea404 @Lazar955