chore(lib/ethclient): add http timeout #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `CloseIdleConnectionsForever` to ethclient. Call it in production use-cases. This aims to mitigate the problem of TCP-keep-alive maintaining long-lived connections to stalled (but alive) RCP servers. This sometimes occurs with QuickNode, when one of the load-balanced upstream servers/nodes stalled, but we remain connected to it, requiring a restart of the affected service to reconnect to a healthy upstream. By periodically closing idle connections, we get best of both worlds, TCP-keep-alive improves performance of most queries since TCP connection doesn't need to be reestablished for each query. But we still reconnect every 5min ensuring good load balancing over time. This also required some cleanup: - Pass in context in production uses of `ethclient.DialContext`. - Remove `ethclient` duplication in `monitor`. issue: none
corverroos
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 30s timeout to all ethclient http requests. This should fix production issue where clients are stuck waiting for response from server.
issue: #3699