fix(lib/contracts): add mutex to caches #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devbugging
reviewed
Oct 10, 2024
lib/contracts/address.go
Outdated
| var ( | ||
| // cached addresses by network. | ||
| addrsCache = map[netconf.ID]Addresses{} | ||
| addrsCache = cache[map[netconf.ID]Addresses]{ | ||
| mu: sync.Mutex{}, |
There was a problem hiding this comment.
no need to initialize it, empty value is fine
Suggested change
| mu: sync.Mutex{}, |
devbugging
approved these changes
Oct 10, 2024
kevinhalliday
force-pushed
the
kh/fix-caches
branch
from
ed847aa to
0806d3d
Compare
chmllr
added a commit
that referenced
this pull request
Oct 14, 2024
The PR #2140 introduced a locking around a cache. Some parts of the critical section seem unrelated to the locking and can be done before without changing the read semantics (because this check happened after the cache read before). issue: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mutex to caches.
issue: none