Skip to content

Probabilistic usage of subsequent buckets #3556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

SFisGOD
Copy link
Contributor

@SFisGOD SFisGOD commented Jun 15, 2021

After conducting a series of experimental tests, it seems that using a subsequent bucket to have a second opinion on the evaluation of a position can be beneficial. However, the precise condition when to call is challenging to find and maybe there is even no such condition, so we just do it probabilistically. This patch also serves to smooth the transition between buckets since the current implementation is quite drastic in changing buckets at the boundary piece counts.

STC:
LLR: 2.96 (-2.94,2.94) <-0.50,2.50>
Total: 56064 W: 4950 L: 4744 D: 46370
Ptnml(0-2): 185, 3831, 19794, 4037, 185
https://tests.stockfishchess.org/tests/view/60c74bbd457376eb8bcaaf4c

LTC:
LLR: 2.97 (-2.94,2.94) <0.50,3.50>
Total: 60648 W: 2104 L: 1929 D: 56615
Ptnml(0-2): 25, 1739, 26629, 1898, 33
https://tests.stockfishchess.org/tests/view/60c7b780457376eb8bcaafb1

Bench: 4971722

@Sopel97
Copy link
Member

Sopel97 commented Jun 15, 2021

I think this should only be done when adjusted == true

xoto10 pushed a commit to xoto10/stockfish-xoto10 that referenced this pull request Jun 15, 2021
@SFisGOD
Copy link
Contributor Author

SFisGOD commented Jun 15, 2021

I think this should only be done when adjusted == true

Yes, like in #3492

@vondele
Copy link
Member

vondele commented Jun 15, 2021

can you please rebase this test on the new net, correct it for the 'adjusted' argument of evaluate, and give it one more test on fishtest?

@SFisGOD
Copy link
Contributor Author

SFisGOD commented Jun 15, 2021

@vondele Direct LTC?

@vondele
Copy link
Member

vondele commented Jun 15, 2021

yes, that's fine with me.

@SFisGOD
Copy link
Contributor Author

SFisGOD commented Jun 15, 2021

@SFisGOD SFisGOD closed this Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants