tablebase file checks (#1911) #1927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this addresses partially issue official-stockfish#1911 in that it documents the command for verifying the md5sum of downloaded tablebase files. Additionally, a quick check of the file size (the size of each tb file modulo 64 is 16 as pointed out by @syzygy1) has been implemented. No functional change.
|
Patch is good for me. Just a little nitpicking, please keep *mapping together with *baseAddress if (statbuf.st_size % 64 != 16)
{
std::cerr << "Corrupt tablebase file " << fname << std::endl;
exit(1);
}
*mapping = statbuf.st_size;
*baseAddress = mmap(nullptr, statbuf.st_size, PROT_READ, MAP_SHARED, fd, 0);
|
|
Merged via bb843a0, thanks! I have also used |
joergoster
pushed a commit
to joergoster/Stockfish-old
that referenced
this pull request
Feb 21, 2019
This addresses partially issue #1911 in that it documents in our Readme the command that users can use to verifying the md5sum of their downloaded tablebase files. Additionally, a quick check of the file size (the size of each tablebase file modulo 64 is 16 as pointed out by @syzygy1) has been implemented at launch time in Stockfish. Closes official-stockfish/Stockfish#1927 and official-stockfish/Stockfish#1911 No functional change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this addresses partially issue #1911 in that it documents the command for verifying the md5sum of downloaded tablebase files.
Additionally, a quick check of the file size (the size of each tb file modulo 64 is 16 as pointed out by @syzygy1) has been implemented.
No functional change.