Skip to content

Allow to "make test-deps" and install modules needed for "make check" #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2024

Conversation

jimklimov
Copy link
Contributor

@jimklimov jimklimov commented May 28, 2024

Impacts also GitHub build flows, as well as developer iterations which are now locally more convenient.

Note: uncertain how much make check differs from ./test.sh but that is a separate matter, I guess.

The suite is quite intensive (at least, on a pretty beefy laptop with Ubuntu in WSL2 it took over an hour):

:; make check
cd thirdparty && make  test-deps
make[1]: Entering directory '/home/jim/znapzend/thirdparty'
** Installing Test Dependencies using Carton install
Installing modules using /home/jim/znapzend/cpanfile
Successfully installed URI-5.28
...
Successfully installed Devel-Cover-Report-Coveralls-0.32
22 distributions installed
Complete! Modules were installed into /home/jim/znapzend/thirdparty
make[1]: Leaving directory '/home/jim/znapzend/thirdparty'
Making check in lib
make[1]: Entering directory '/home/jim/znapzend/lib'
...
make[1]: Nothing to be done for 'check-am'.
make[1]: Leaving directory '/home/jim/znapzend'
NOTE: You may want to also/instead run test.sh
/usr/bin/perl -Ithirdparty/lib/perl5 "-MExtUtils::Command::MM" "-e" "test_harness(1, 'lib','thirdparty/lib/perl5')" ./t/*.t
./t/autoscrub.t ..............
1..10
ok 1 - use ZnapZend::ZFS;
...
All tests successful.
Files=6, Tests=417, 3462 wallclock secs ( 7.47 usr 11.06 sys + 2975.59 cusr 1144.06 csys = 4138.18 CPU)
Result: PASS

Impacts also GitHub build flows, as well as developer iterations

Signed-off-by: Jim Klimov <[email protected]>
Copy link

@check-spelling-bot Report jimklimov/znapzend: fix-make-check into -> oetiker/znapzend: a5480d1

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

spamming

Previously acknowledged words that are now absent Balert Bcreate Bdebug Bdelete Bedit Berr Bexport Bimport Binfo Bnoaction Bnot Bpidfile Bpost Bpre Bsyslog Bwarning Bzfs Bznapzend Bznapzendzetup Bznapzendztatz cpanm cpanmin CPANSNAPV crt DBD DESTDIR distdir DTDs endif EXTRADIST forkcall Icommand Icommon Icreate Idataset Idestroy Idocuments Iexport Ifacility Ifeature Ifilepath Ihome Ilimited imandir Inumber Ioptions Ipath Ipictures Irecursive Isend Iskip Isnapshots Isnapsuffix Isources Itank Ithirdparty Itimeout Iusbbackup Iuser Ivalue Iznapzendzetup lpr nobase notest nroff ODBC SUBDIRS svcdir troff unicode utf vroff xargs 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the https://github.com/oetiker/znapzend repository
on the master branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/oetiker/znapzend/actions/runs/9267610381/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (664) from .github/workflows//spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:software-terms/dict/softwareTerms.txt 1288 82 18
cspell:php/dict/php.txt 1689 59 6
cspell:python/src/python/python-lib.txt 2417 54 6
cspell:node/dict/node.txt 891 58 5
cspell:filetypes/filetypes.txt 264 19 4

Consider adding them (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:software-terms/dict/softwareTerms.txt
          cspell:php/dict/php.txt
          cspell:python/src/python/python-lib.txt
          cspell:node/dict/node.txt
          cspell:filetypes/filetypes.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml):

check_extra_dictionaries: ''

@oetiker oetiker merged commit 759cccf into oetiker:master May 29, 2024
4 checks passed
@jimklimov jimklimov deleted the fix-make-check branch May 29, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants