feat: coalesce concurrent authentication calls #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
wolfy1339
reviewed
Apr 2, 2025
wolfy1339
approved these changes
Apr 2, 2025
|
🎉 This PR is included in version 7.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Really great work y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #688
Before the change?
getInstallationAuthenticationwould result in redundant token acquisition (generate a JWT, post to/app/installations/.../access_tokens, and cache the token, with the last one winning)After the change?
getInstallationAuthenticationwill all resolve to the same promise, ensuring that the token is only acquired once.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
No breaking changes. The only observable impact should be that API usage goes down and request throughput goes up when concurrent requests are made that need authentication. The improvement is most noticeable without octokit/plugin-throttling.js#779, since currently authentications are treated as writes, meaning they incur an automatic 1 second penalty between them.