Skip to content

fix(deps): update octokit monorepo (major) #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 18, 2023
Merged

fix(deps): update octokit monorepo (major) #513

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
ce49779
fix(deps): update octokit monorepo
renovate[bot] Jul 10, 2023
9a984f4
todo fix proxy test by replacing http agent/fetch mock with custom fetch
nickfloyd Jul 11, 2023
8d6afaa
build: switch to `@gr2m/fetch-mock`
wolfy1339 Jul 11, 2023
b89fa45
updates the plugin to use a custom fetch as suggested
nickfloyd Jul 13, 2023
7f1f87a
Merge branch 'renovate/major-octokit-monorepo' of https://github.com/…
nickfloyd Jul 13, 2023
45937ec
moves undici to deps and removes https-proxy-agent
nickfloyd Jul 13, 2023
a68deda
Serialization issue as seen in core
nickfloyd Jul 13, 2023
9647263
adds local server for the tests to call
nickfloyd Jul 14, 2023
e5de683
Undo skip for array of smoke tests
kfcampbell Jul 17, 2023
f0cfdb9
Undo skip on another test
kfcampbell Jul 17, 2023
a23ec0d
WIP checkpoint with all lines covered but one test broken
kfcampbell Jul 17, 2023
e35075d
WIP checkpoint with tests passing
kfcampbell Jul 17, 2023
5f82b61
Use localhost for consistency
kfcampbell Jul 17, 2023
f3821ab
Remove extraneous console.log statements
kfcampbell Jul 17, 2023
b970c0d
Strongly type Server
kfcampbell Jul 17, 2023
b4dddca
Some test cleanup
kfcampbell Jul 17, 2023
dd21769
WIP comment out spy
kfcampbell Jul 17, 2023
dcd0341
Refactor customFetch tests to own describe block
kfcampbell Jul 17, 2023
3670f90
Comment fix
kfcampbell Jul 17, 2023
ad90bcd
Remove redundant tests
kfcampbell Jul 17, 2023
6458785
Remove unnecessary tests
kfcampbell Jul 18, 2023
2f41cd5
Revert "Remove unnecessary tests"
kfcampbell Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
187 changes: 71 additions & 116 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
"author": "Gregor Martynus (https://twitter.com/gr2m)",
"license": "MIT",
"dependencies": {
"@octokit/auth-action": "^3.0.0",
"@octokit/core": "^4.0.0",
"@octokit/plugin-paginate-rest": "^7.0.0",
"@octokit/plugin-rest-endpoint-methods": "^8.0.0",
"@octokit/types": "^10.0.0",
"@octokit/auth-action": "^4.0.0",
"@octokit/core": "^5.0.0",
"@octokit/plugin-paginate-rest": "^8.0.0",
"@octokit/plugin-rest-endpoint-methods": "^9.0.0",
"@octokit/types": "^11.0.0",
"https-proxy-agent": "^7.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions test/smoke.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ describe("Smoke test", () => {
expect(data).toStrictEqual({ ok: true });
});

it.each(["HTTPS_PROXY", "https_proxy", "HTTP_PROXY", "http_proxy"])(
it.skip.each(["HTTPS_PROXY", "https_proxy", "HTTP_PROXY", "http_proxy"])(
"Uses https-proxy-agent with %s env var",
async (https_proxy_env) => {
process.env.GITHUB_TOKEN = "secret123";
Expand Down Expand Up @@ -219,7 +219,7 @@ describe("Smoke test", () => {
},
);

it("Uses the explicitly provided request.agent value if it's provided", async () => {
it.skip("Uses the explicitly provided request.agent value if it's provided", async () => {
process.env.GITHUB_TOKEN = "secret123";
process.env.GITHUB_ACTION = "test";
process.env.HTTPS_PROXY = "https://127.0.0.1";
Expand Down