Allow for FiniteDatetimeRange to be considered as "half-open"
#216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feds01
force-pushed
the
augment-is-half-finite-datetime-range
branch
from
c5e8e3d to
9c6b29b
Compare
feds01
commented
Jun 3, 2025
| @@ -1200,7 +1200,14 @@ def _is_datetime_range(value: Any) -> bool: | |||
| ) | |||
|
|
|||
|
|
|||
| def _is_datetime_range_and_bounded(value: Any) -> bool: | |||
| return _is_datetime_range(value) and ( | |||
There was a problem hiding this comment.
🍷 We already check with _is_datetime_range that both start and end must be datetime | None. The second part of this clause is checking whether we at least have a start or an end, meaning that we'd have a half-finite range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_is_half_finite_datetime_rangecurrently checks whether that passeditem is indeed a
HalfFiniteRange. We change the implementation to allowfor both
HalfFiniteRangeandFiniteDatetimeRangeto be passed in andtreated as the same item. This is because a
HalfFiniteRangeis aa superset of
FiniteDatetimeRangeand we want to allow for bothtypes to be passed in and treated as the same item.