Added void* cast to suppress trivially-copyable warning #8537
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thank you. Somehow it was the only leftover code doing that, probably because it's not in master branch. (Minor: note that PR are typically done against a dedicated branch, which avoid the accidentally commit noise. It didn't affect me at all here as I squashed the result and the 4 others commits ended up cancelling each others anyhow, but I thought you may want to know) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructor for ImGui_ImplVulkan_ViewportData calls memset on RenderBuffers without a void* cast causing compile warnings