Fix iOS code; fixes entire XCode build for Apple example #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut
added a commit
that referenced
this pull request
Feb 5, 2018
|
Thank you @gerryhernandez, merged. I have however removed the extra .gitignore file you added in the root folder. There's already one in the examples/ folder. If the apple_example/ doesn't creates it outputs under examples/ then perhaps that should be fixed. |
|
Gotcha. I didn't know if that was intentional or not. I'll just fix the outputs next time I touch the Apple example; no real need for a noisy commit/merge. Thanks for taking care of it for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple minor issues with the iOS related code within the Apple example. One is just a typo, the other is an unresolved symbol. I did my best to match the code style of this specific example.