Skip to content

Switch to official setup-python's 3.13t #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ddelange
Copy link
Collaborator

@ddelange ddelange commented Mar 25, 2025

unofficial one had a bug (?) ref #52 (comment)
official one was released ref actions/setup-python#973 (comment)

@ddelange
Copy link
Collaborator Author

ddelange commented Mar 25, 2025

Hi @davidhewitt 👋

despite free-threaded python now being GA on actions/setup-python side, the above-mentioned bug still persists for windows. can you please double check that this is not maturin-action?

if it is not, would you be so kind to open a bug report with your context of maturin's path discovery?

@ngoldbaum
Copy link
Contributor

despite free-threaded python now being GA on actions/setup-python side, the above-mentioned bug still persists for windows. can you please double check that this is not maturin-action?

What you're running into is just how the python.org installer is documented to work on Windows for the free-threaded build. See https://docs.python.org/3.13/using/windows.html#installing-free-threaded-binaries and in particular note:

Python source files and bundled third-party dependencies are shared with the main install.

So I think this is just a huge footgun that setup-python inherits from upstream :(

The only real fix is to separate out the install into its own actions run. Or use a nuget python. See https://py-free-threading.github.io/installing_cpython/#pythonorg-and-nuget-installers.

@ngoldbaum
Copy link
Contributor

We should also try to make setup-uv and the python-build-standalone python builds from uv play more nicely with pyo3. There are rpath issues that block just completely replacing setup-python with setup-uv everywhere it might make sense.

@ddelange
Copy link
Collaborator Author

ddelange commented Mar 25, 2025

Thanks for the context @ngoldbaum!

Will close this PR with that, because with #64 merged it's fine as it is right now.

@ddelange ddelange closed this Mar 25, 2025
@ddelange ddelange deleted the official-3.13t-setup-python branch March 25, 2025 15:46
@oconnor663
Copy link
Owner

Thanks a million both of you for figuring this stuff out. I dread debugging stuff like this 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants