[new release] styled-ppx (0.59.0) #26258
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: ## 0.59.0 - [BREAKING] Change entry point module `CSS` (from `CssJs`) on `styled-ppx.melange`, `styled-ppx.native` and `styled-ppx.rescript` (davesnx/styled-ppx#490) (@davesnx) - [FEATURE] Add support and interpolation for `zoom`, `will-change` and `user-select` properties (davesnx/styled-ppx#489) (@davesnx) - [FEATURE] Support content with interpolation davesnx/styled-ppx#494 (@davesnx) - [FEATURE] Support define CSS variables in global and use CSS variables in properties davesnx/styled-ppx#492 (@davesnx) - [FEATURE] Support overflow with 2 values - [FEATURE] Make animation-name abstract (@davesnx) - [FIX] Add 100 unsupported properties, which will render properly (davesnx/styled-ppx#489) (@davesnx) - [FIX] Inline all CSS.Var and CSS.Cascading in properties (davesnx/styled-ppx#495) (@davesnx) - [FIX] Color with support for rgba/hsla and others with calc/min and max (davesnx/styled-ppx#495) (@davesnx) - [FIX] Warning of kebab-case on emotion client side (davesnx/styled-ppx#493) (@davesnx) ## 0.58.1 - [BREAKING] FontFamilyName.t is now a string (@davesnx) - [FIX] Make unsafe calls from "Cascading" be camelCase to avoid emotion's warning davesnx/styled-ppx#488 (@davesnx) - [FIX] Keep classname when ampersand is at the end of the selector (@davesnx) - [FIX] Fix fontFace in both melange and native (@davesnx) ## 0.58.0 - [FEATURE] Initial @container support davesnx/styled-ppx#476 (@zakybilfagih) - [FIX] Make selector nested maintain other selectors davesnx/styled-ppx#486 (@davesnx) - [BREAKING] Remove `Css` module, `styled_label` and friends davesnx/styled-ppx#487 (@davesnx) - [BREAKING] Merge styled-ppx.css and styled-ppx.emotion into styled-ppx.melange davesnx/styled-ppx#487 (@davesnx) - [BREAKING] Merge styled-ppx.css-native and styled-ppx.emotion-native into styled-ppx.native davesnx/styled-ppx#487 (@davesnx) - [BREAKING] Merge styled-ppx.css-native and styled-ppx.emotion-native into styled-ppx.native davesnx/styled-ppx#487 (@davesnx) - [BREAKING] Remove PseudoClass and PseudoClassParam davesnx/styled-ppx#487 (@davesnx) - Remove functor from Css_Js_Core davesnx/styled-ppx#487 (@davesnx) - Remove melange.js and melange.belt from styled-ppx.melange davesnx/styled-ppx#487 (@davesnx) - Remove server-reason-react.js and server-reason-react.belt from styled-ppx.native davesnx/styled-ppx#487 (@davesnx) ## 0.57.1 - Remove public_name from alcotest_extra davesnx/styled-ppx#484 (@davesnx) - Fix nesting for selectors (and pseudo) in native davesnx/styled-ppx#483 (@davesnx) ## 0.57.0 - Improvement for locations in both code-gen and error reporting by @davesnx in davesnx/styled-ppx#456 - Support css min and max functions by @lubegasimon in davesnx/styled-ppx#411 - Update docs by @zakybilfagih in davesnx/styled-ppx#457 - update server-reason-react pin to main branch by @zakybilfagih in davesnx/styled-ppx#460 - Native support for styled.{{tag}} by @zakybilfagih in davesnx/styled-ppx#461 - Fix linear-gradient and radial-gradient by @davesnx in davesnx/styled-ppx#464 - Add getting started docs by @zakybilfagih in davesnx/styled-ppx#459 - escape curly on remote markdown content by @zakybilfagih in davesnx/styled-ppx#466 - Add Melange and native instructions by @davesnx in davesnx/styled-ppx#465 - Global styles for native server on emotion by @pedrobslisboa in davesnx/styled-ppx#468 - Style HTML tag by @pedrobslisboa in davesnx/styled-ppx#467 - [emotion native] Fix nested pseudoelements by @davesnx in davesnx/styled-ppx#470 - Transform with variable handle unsafe interpolation by @zakybilfagih in davesnx/styled-ppx#471 - Add depext for @emotion/css >= 11.0.0 by @feihong in davesnx/styled-ppx#473 - Add support for transition by @zakybilfagih in davesnx/styled-ppx#472 - Fix animation codegen by @zakybilfagih in davesnx/styled-ppx#475 - Fix error line number coming from parser by @zakybilfagih in davesnx/styled-ppx#478 - Polish emotion-native by @davesnx in davesnx/styled-ppx#481 - Rename `render_style_tag` to `get_stylesheet` (@davesnx) - Docs: Explain show server rendered stylesheets work natively by @ManasJayanth in davesnx/styled-ppx#480 ## 0.56.0 - Improvement for locations in both code-gen and error reporting (davesnx/styled-ppx#456) by @davesnx - Support css min and max functions (davesnx/styled-ppx#411) by @lubegasimon - Update docs (davesnx/styled-ppx#457) by @zakybilfagih - Native support for styled.{{tag}} (davesnx/styled-ppx#461) by @zakybilfagih - background-clip: text support by @davesnx - Fix linear-gradient and radial-gradient (davesnx/styled-ppx#464) by @davesnx - Rename emotion-hash into murmur2 and remove public testing cli by @davesnx - Use server-reason-react from opam by @davesnx
mseri
reviewed
Jul 22, 2024
| "-j" | ||
| jobs | ||
| "@install" | ||
| "@runtest" {with-test} |
There was a problem hiding this comment.
Suggested change
| "@runtest" {with-test} |
Tests are failing all over the place, but if I remember correctly they cannot work in the CI. Am I correct?
There was a problem hiding this comment.
It's very rare, I disabled some tests that relied on a npm dependency last release, but I don't understand why all cram tests do not work :/
I'm happy to disable the tests, since I run them on each PR/branch/tag on my repo
There was a problem hiding this comment.
I have no idea about the failure, I am not really familiar with reason, but indeed they still all look like the ones in #26192 (comment) :
# + Error: _build/default/input.re.ml does not exist
There was a problem hiding this comment.
The only different one (which may have also been there in the past) is
# (cd _build/default/packages/runtime/test && ./test.exe)
# Testing `styled-ppx.native'.
# This run has ID `AUFX4VMP'.
#
# .........F......................................................................
# .................
#
# ┌──────────────────────────────────────────────────────────────────────────────┐
# │ [FAIL] CSS 9 style_tag. │
# └──────────────────────────────────────────────────────────────────────────────┘
# ASSERT should be equal
# FAIL should be equal
#
# Expected: `"<style data-reactroot=\"\" data-emotion=\"css 18zdck7 1gx3jof 13o7eu2\" data-s>html{line-height:1.15;} @keyframes animation-1gx3jof { 0% { -webkit-transform: rotate(0deg); -moz-transform: rotate(0deg); -ms-transform: rotate(0deg); transform: rotate(0deg); } 100% { -webkit-transform: rotate(-360deg); -moz-transform: rotate(-360deg); -ms-transform: rotate(-360deg); transform: rotate(-360deg); } } .css-13o7eu2 { display: block; }</style>"'
#
# Received: `"<style data-emotion=\"css 18zdck7 1gx3jof 13o7eu2\" data-s>html{line-height:1.15;} @keyframes animation-1gx3jof { 0% { -webkit-transform: rotate(0deg); -moz-transform: rotate(0deg); -ms-transform: rotate(0deg); transform: rotate(0deg); } 100% { -webkit-transform: rotate(-360deg); -moz-transform: rotate(-360deg); -ms-transform: rotate(-360deg); transform: rotate(-360deg); } } .css-13o7eu2 { display: block; }</style>"'
#
# Raised at Alcotest_engine__Test.check in file "src/alcotest-engine/test.ml", lines 200-210, characters 4-19
# Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 181, characters 17-23
# Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35
#
# Logs saved to `~/.opam/5.2/.opam-switch/build/styled-ppx.0.59.0/_build/default/packages/runtime/test/_build/_tests/styled-ppx.native/CSS.009.output'.
but does not feel like a real error, it is just omitting the empty attribute
There was a problem hiding this comment.
Right, it's probably from another dep. It is publishing latest (#26269) and updating here later
There was a problem hiding this comment.
Waiting for #26275 to merge
There was a problem hiding this comment.
I fixing the issues in #26276
The test failing is a old server-reason-react version and input.re.ml not found is a dune bug fix on dune describe pp when input is reason
There was a problem hiding this comment.
I fixing the issues in #26276
Does this mean you want to close this PR here? Or are both relevant?
|
This is no longer relevant. Thanks for the ping @raphael-proust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-safe styled components for ReScript and Melange
CHANGES:
0.59.0
CSS(fromCssJs) onstyled-ppx.melange,styled-ppx.nativeandstyled-ppx.rescript(Rename to CSS davesnx/styled-ppx#490) (@davesnx)zoom,will-changeanduser-selectproperties (Add all properties davesnx/styled-ppx#489) (@davesnx)0.58.1
0.58.0
Cssmodule,styled_labeland friends Remove Css, styled_label and friends davesnx/styled-ppx#487 (@davesnx)