Skip to content

Backend template #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jul 4, 2024
Merged

Backend template #9

merged 31 commits into from
Jul 4, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Jul 2, 2024

This change is Reviewable

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 91 of 91 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)


api/models/fruit.py line 24 at r1 (raw file):

    is_citrus = models.BooleanField(_("is citrus"))

    expires_on = models.DateField(_("expires on"))

no new lines in between fields pls

Code quote:

    name = models.CharField(_("name"), max_length=50)

    is_citrus = models.BooleanField(_("is citrus"))

    expires_on = models.DateField(_("expires on"))

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)

Copy link
Contributor Author

@SKairinos SKairinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 90 of 91 files reviewed, 2 unresolved discussions (waiting on @faucomte97)


api/models/fruit.py line 24 at r1 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

no new lines in between fields pls

Done.

Copy link
Contributor

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@SKairinos SKairinos merged commit 2582ef0 into development Jul 4, 2024
8 checks passed
@SKairinos SKairinos deleted the backend_template branch July 4, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants