Add ability to update memories from the user UI and memory tools. #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
cjellick,
thedadams,
ivyjeong13,
tybalex,
StrongMonkey and
g-linville
njhale
force-pushed
the
enhance-memory-rm-update
branch
from
c8f7ca6 to
7025c3a
Compare
cjellick
approved these changes
Apr 22, 2025
thedadams
approved these changes
Apr 22, 2025
| return apierrors.NewBadRequest("id should not be provided") | ||
| } | ||
|
|
||
| if memory.CreatedAt != (types.Time{}) { |
There was a problem hiding this comment.
Suggested change
| if memory.CreatedAt != (types.Time{}) { | |
| if memory.CreatedAt != types.Time{} { |
There was a problem hiding this comment.
This change doesn't compile
pkg/api/handlers/memories.go
Outdated
Comment on lines
191
to
192
| var updatedMemory types.Memory | ||
| memoryFound := false |
There was a problem hiding this comment.
nit:
Suggested change
| var updatedMemory types.Memory | |
| memoryFound := false | |
| var ( | |
| updatedMemory types.Memory | |
| memoryFound bool | |
| ) |
Redesign the memories API to hide the memory set abstraction from clients. This also adds an update endpoint for memories and changes memory IDs from a hash of the content to UUIDs. Signed-off-by: Nick Hale <[email protected]>
Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance-memory-rm-update
branch
from
7025c3a to
e4160d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to update memories from the user UI and API/client.
This change also refactors the API to hide
MemorySetsfrom clients. They are an implementation detail of how memories are stored in the backend and don't need to be exposed to clients.e.g. Editing a memory via the UI
Screen.Recording.2025-04-21.at.11.23.41.PM.mov
e.g. Editing a memory via chat
Screen.Recording.2025-04-21.at.11.25.39.PM.mov
e.g. Deleting a memory via chat
Screen.Recording.2025-04-21.at.11.41.18.PM.mov
Addresses part of #2612