Skip to content

enhance: allow looping over JSON string lists in addition to datasets #2665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025

Conversation

g-linville
Copy link
Member

@g-linville g-linville commented Apr 22, 2025

Copy link
Contributor

@cjellick cjellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but would like @thedadams to review too

@thedadams thedadams self-requested a review April 22, 2025 14:13
Copy link
Contributor

@thedadams thedadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one issue with ignoring the error.

Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville requested a review from thedadams April 22, 2025 14:52
Signed-off-by: Grant Linville <[email protected]>
@g-linville g-linville merged commit bad02e3 into obot-platform:main Apr 22, 2025
2 checks passed
@g-linville g-linville deleted the loop-over-json-strings branch April 22, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants