fix: check table existence before deleting sessions #2579
Merged
+12
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <[email protected]>
StrongMonkey
approved these changes
Apr 16, 2025
thedadams
approved these changes
Apr 16, 2025
pkg/gateway/client/session.go
Outdated
Comment on lines
85
to
89
| var exists bool | ||
| if err := db.Raw("SELECT EXISTS (SELECT FROM information_schema.tables WHERE table_name = ?)", tableName).Scan(&exists).Error; err != nil { | ||
| return false, err | ||
| } | ||
| return exists, nil |
There was a problem hiding this comment.
nit: Does something like this work?
Suggested change
| var exists bool | |
| if err := db.Raw("SELECT EXISTS (SELECT FROM information_schema.tables WHERE table_name = ?)", tableName).Scan(&exists).Error; err != nil { | |
| return false, err | |
| } | |
| return exists, nil | |
| return db.Migrator().TableExists(tableName) |
There was a problem hiding this comment.
Yep, this is much better, thanks
Signed-off-by: Grant Linville <[email protected]>
thedadams
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that it was possible to get into a state where the user would get a 500 when trying to log out of all other sessions. This would happen if they had an identity tied to a previously configured but now deconfigured auth provider, so that sessions table didn't exist. This fixes that by checking for the table before we try to delete sessions from it.