Fix: fix unexpected scroll behavior in textarea #2536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daishan Peng <[email protected]>
ivyjeong13
reviewed
Apr 15, 2025
| } | ||
| }; | ||
| } | ||
|
|
||
| function findScrollContainer(el: HTMLElement): HTMLElement | null { |
There was a problem hiding this comment.
Wondering if this is unnecessary? I think we should be using this action on a textarea and setting that with a scroll overflowY if we're using autoHeight
There was a problem hiding this comment.
I think the problem here is that the parent div is scrollable, not the textarea. I tried to set on textarea and it didn't work.
ivyjeong13
reviewed
Apr 15, 2025
| export function autoHeight(node: HTMLTextAreaElement) { | ||
| const scrollContainer = findScrollContainer(node); |
There was a problem hiding this comment.
Screen.Recording.2025-04-15.at.10.20.06.AM.mov
Looks like it turns the text area into a crazy long height for me?
There was a problem hiding this comment.
Hmm, can't see your video. but the height looks fine to me?
There was a problem hiding this comment.
Hmm, can't see your video. but the height looks fine to me?
Oh oops, sorry! Didn't realize the video isn't working, here's a Loom!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2507