Add client certificate option. #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dencrypt-jacob , Thanks for the PR and sorry for the late reply - I've lost this PR among other notifications. So far changes look good. And this feature is definitely the must-have for this and other TLS modules. I have to make some tests - will get back to you. Regards, |
|
Hey @lganzzzo. Thanks for approving my other PRs (linking oatpp-test). |
|
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to use a client certificate and a private key when setting up a client connection.
I added a new createDefaultClientConfigShared method for this purpose.
Also, I prefer the mbedtls methods using memory buffers instead of files, so that's what I did.
And... I used std::string, not const char*.
Please let me know what you think about the changes.