updategrubcore: Fix both failure and success always reported

[matejmatuska]

Both the "Grub core update failed" and "Grub core successfully updated" reports were printed unconditionally.

This introduces the missing conditions that check if there are any failed/successful updates.

[github-actions]

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
If you want to request a review or rebuild a package in copr, you can use following commands as a comment:

• review please @oamg/developers to notify leapp developers of the review request
• /packit copr-build to submit a public copr build using packit

Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use /packit test oamg/leapp#42

To launch regression testing public members of oamg organization can leave the following comment:

• /rerun to schedule basic regression tests using this pr build and latest upstream leapp build as artifacts
• /rerun 42 to schedule basic regression tests using this pr build and leapp*PR42* as artifacts
• /rerun-sst to schedule sst tests using this pr build and latest upstream leapp build as artifacts
• /rerun-sst 42 to schedule sst tests using this pr build and leapp*PR42* as artifacts

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra.

[matejmatuska]

TEST

I tested the case where just some, but not all, of the grub devices fail to update with a hacked in device, because this scenario is difficult to reproduce on the system. I used the internal Vagrant box and did IPU 7->8.

The system only has /dev/vda:

[root@leapp-20230816145245 ~]# lsblk
NAME                                      MAJ:MIN RM SIZE RO TYPE MOUNTPOINT
vda                                       252:0    0  40G  0 disk
├─vda1                                    252:1    0   1G  0 part /boot
└─vda2                                    252:2    0  39G  0 part
  ├─rhel_ibm--p8--kvm--03--guest--02-root 253:0    0  38G  0 lvm  /
  └─rhel_ibm--p8--kvm--03--guest--02-swap 253:1    0   1G  0 lvm  [SWAP]

I patched the /usr/share/leapp-repository/repositories/system_upgrade/common/actors/updategrubcore/actor.py as follows:

def process(self):
    ff = next(self.consume(FirmwareFacts), None)
    if ff and ff.firmware == 'bios':
        grub_devs = grub.get_grub_devices()
        if grub_devs:
            grub_devs.append('/dev/vdb') # <-------------------------- PATCHED THIS IN
            update_grub_core(grub_devs)
        else:
            api.current_logger().warning('Leapp could not detect GRUB devices')

The failure report after the upgrade:

----------------------------------------
Risk Factor: high
Title: GRUB core update failed
Summary: GRUB was successfully updated on the following devices: /dev/vda,
however GRUB update failed on the following devices: /dev/vdb
Remediation: [hint] Please run "grub2-install <GRUB_DEVICE>" manually after upgrade
Key: 54ba8c51e17b2088df653f3df0f1ae490f9ead88
----------------------------------------

[pirat89]

Seems to be ok now. Tested manually positive scenario for standard upgrade in my VM, works as expected.