[WIP] checkfips: Allow FIPS upgrades in 8.8 #1056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addupgradebootentry actor does already preserve fips=1 on the kernel command line, so the upgrade initramfs is correctly booted in FIPS mode. The upgrade initramfs does not correctly enable FIPS mode for all libraries due to a bug in dracut that also affects all normal boot environments generated by dracut. See rhbz#2176560 for a report of this problem. Once this is fixed, we can enable leapp upgrades in FIPS mode. The systemd-nspawn container in the upgrade initramfs does correctly pass /proc and has the required files (OpenSSL FIPS provider, OpenSSL configuration file, crypto-policies, GnuTLS HMAC integrity checksums) installed, so that part already behaves as expected in a FIPS uprgade scenario. See: OAMG-7824 Signed-off-by: Clemens Lang <[email protected]>
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
neverpanic
changed the title
|
See #1053. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
addupgradebootentryactor does already preservefips=1on the kernel command line, so the upgrade initramfs is correctly booted in FIPS mode.The upgrade initramfs does not correctly enable FIPS mode for all libraries due to a bug in dracut that also affects all normal boot environments generated by dracut. See rhbz#2176560 for a report of this problem. Once this is fixed, we can enable leapp upgrades in FIPS mode.
The systemd-nspawn container in the upgrade initramfs does correctly pass
/procand has the required files (OpenSSL FIPS provider, OpenSSL configuration file, crypto-policies, GnuTLS HMAC integrity checksums) installed, so that part already behaves as expected in a FIPS uprgade scenario.See: OAMG-7824