Skip to content

Shibboleth authentication #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 13, 2013

Conversation

simong
Copy link
Contributor

@simong simong commented Mar 12, 2013

This PR replaces the SAML 2 authenticator with Shibboleth.

It has been tested with the following identity providers:

It currently relies on a custom branch of the passport-saml library for which there is a PR pending.

Documentation for setting it up is available on Confluence.

*
* Configuration namespace for the saml logic
*
* @param {String} SAMLParserJarPath The path towards the Java binary that can be used to decrypt SAML messages. This only needs to be configured if you want to enable the Shibboleth strategy. See https://github.com/sakaiproject/SAMLParser
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 spaces after param

@nicolaasmatthijs
Copy link
Contributor

Some small comments remain.

 * Using simong/passport-saml#master
 * Made the SP certificate global admin only
 * Added some docs
 * Styling issues
@simong
Copy link
Contributor Author

simong commented Mar 12, 2013

Followed up to all the addressed issues.

@nicolaasmatthijs
Copy link
Contributor

@simong : Looks like there is a merge conflict here

@simong
Copy link
Contributor Author

simong commented Mar 13, 2013

Merge conflict resolved.

@nicolaasmatthijs
Copy link
Contributor

Travis build is failing with the following error:

 1) Authentication External authentication verify disabling the Shibboleth strategy:

  AssertionError: 500 == 401
      at Request.verifyEndpointIsDisabled [as _callback] (/home/travis/build/sakaiproject/Hilary/node_modules/oae-authentication/tests/test-external-strategies.js:86:36)
      at Request.init.self.callback (/home/travis/build/sakaiproject/Hilary/node_modules/request/main.js:127:22)
      at Request.EventEmitter.emit (events.js:99:17)
      at Request.<anonymous> (/home/travis/build/sakaiproject/Hilary/node_modules/request/main.js:767:16)
      at Request.EventEmitter.emit (events.js:126:20)
      at IncomingMessage.Request.start.self.req.self.httpModule.request.buffer (/home/travis/build/sakaiproject/Hilary/node_modules/request/main.js:729:14)
      at IncomingMessage.EventEmitter.emit (events.js:126:20)
      at IncomingMessage._emitEnd (http.js:366:10)
      at HTTPParser.parserOnMessageComplete [as onMessageComplete] (http.js:149:23)
      at Socket.socketOnData [as ondata] (http.js:1485:20)

simong added 2 commits March 13, 2013 15:59
* master:
  Added test case for 418 status code
  Add 418 error code to Array of codes in oae-rest util
  iterateAll PR Follow-up: Fixed superficial styling issues.
  Content iterateAll fix.
  Switch from 500 to 418 http error for tenant that is not available/initialized.
@simong
Copy link
Contributor Author

simong commented Mar 13, 2013

That's due to XSS being merged in and /api/auth/saml2 being replaced with /api/auth/shibboleth.

I've committed and pushed a fix.

@nicolaasmatthijs nicolaasmatthijs merged commit b83006e into oaeproject:master Mar 13, 2013
@nicolaasmatthijs
Copy link
Contributor

Merged. We have shibboleth authentication now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants