-
Notifications
You must be signed in to change notification settings - Fork 96
Shibboleth authentication #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shibboleth authentication #416
Conversation
* | ||
* Configuration namespace for the saml logic | ||
* | ||
* @param {String} SAMLParserJarPath The path towards the Java binary that can be used to decrypt SAML messages. This only needs to be configured if you want to enable the Shibboleth strategy. See https://github.com/sakaiproject/SAMLParser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 spaces after param
Some small comments remain. |
* Using simong/passport-saml#master * Made the SP certificate global admin only * Added some docs * Styling issues
Followed up to all the addressed issues. |
@simong : Looks like there is a merge conflict here |
Merge conflict resolved. |
Travis build is failing with the following error:
|
* master: Added test case for 418 status code Add 418 error code to Array of codes in oae-rest util iterateAll PR Follow-up: Fixed superficial styling issues. Content iterateAll fix. Switch from 500 to 418 http error for tenant that is not available/initialized.
That's due to XSS being merged in and /api/auth/saml2 being replaced with /api/auth/shibboleth. I've committed and pushed a fix. |
Merged. We have shibboleth authentication now |
This PR replaces the SAML 2 authenticator with Shibboleth.
It has been tested with the following identity providers:
It currently relies on a custom branch of the passport-saml library for which there is a PR pending.
Documentation for setting it up is available on Confluence.