feat(unsubscribe): merge n1-unsubscribe plugin #3154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix several styling issues - Adjust the generated size of the thumbnail preview to fill all of the available space
This is a temporary fix which adds defensive code to prevent duplicate results from being returned from the thread search query which causes N1 to enter a loop and freeze (#3001). Duplicate results from the search query likely indicate that a thread was indexed twice, which was not the case before. The cause for this is still at large.
Although some word-wrapping may look better at 800px, it looks much worse when we can't properly display html emails that are meant for a wider area. It also just seems a little weird to limit our users in this way.
This reverts commit d7c79f5.
This reverts commit c926f61.
Summary: Save the final state of the TaskQueue to the database before window gets unloaded Test Plan: Manual Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D3408
…ucceeds only once Summary: This commit adds a new option to NylasAPIRequest api to allow users to specify requests that should only ever be executed once, once they succeed. This is done via saving a hash of some of the requests properties to the filesystem. Specifically regarding send, this ensures that a draft never be sent twice from N1. We ran into this case once when the final state of the TaskQueue wasn't saved to the database before the N1 app closed. In this case, a PerformSendActionTask that was supposed to be dequeued, was restored to the task queue again when N1 restarted, causing the draft to be sent twice. Test Plan: Manual Reviewers: evan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D3407
Test Plan: Gotta test a Travis build Reviewers: evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D3676
This reverts commit efe8fea.
Conflicts: internal_packages/preferences/lib/tabs/update-channel-section.jsx
Conflicts: spec/auto-update-manager-spec.coffee src/browser/auto-update-manager.es6
Summary: As discussed --- we need to make those changes to make the autoupdater work across versions. Test Plan: Will run a build. Reviewers: evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D3701
It turns out that Squirrel checks for update at program launch. In some cases, it would put Pro users on the "nylas-mail" channel because that's the default channel if you don't pass a preferredChannel.
Because of MacOS Gatekeeper path randomization issues (Squirrel/Squirrel.Mac#182) we need the user to move the app themselves. Changed the dialog to ask them to do this politely. Conflicts: internal_packages/verify-install-location/lib/main.es6
Use staging autoupdater for staging. fixed failing test Fix autoupdater – we were using the wrong command. Revert "Bump version to 1.5.0" Temporarily reverting this because I need to test the upgrade path from 0.4.2 => 1.5.0 Revert "Revert "Bump version to 1.5.0"" Had to do this to test the autoupdater. [fix] [channel drop-down list] Show the stable channel in all cases. Conflicts: internal_packages/preferences/lib/tabs/update-channel-section.jsx Fix broken autoupdater, for reals. [master] Replace "Nylas N1" by "Nylas Mail" in build scripts Summary: As discussed --- we need to make those changes to make the autoupdater work across versions. Test Plan: Will run a build. Reviewers: evan Reviewed By: evan Differential Revision: https://phab.nylas.com/D3701 Revert "Revert "Revert "Bump version to 1.5.0""" Need to set the version to 0.4.402 for testing purposes. Set preferredChannel in the autoupdater instead of in the ChannelStore It turns out that Squirrel checks for update at program launch. In some cases, it would put Pro users on the "nylas-mail" channel because that's the default channel if you don't pass a preferredChannel. Conflicts: src/flux/stores/update-channel-store.es6 Set the autoupdater preferredChannel to stable. Don't try to move the app file to the Application folder ourselves Because of MacOS Gatekeeper path randomization issues (Squirrel/Squirrel.Mac#182) we need the user to move the app themselves. Changed the dialog to ask them to do this politely. Conflicts: internal_packages/verify-install-location/lib/main.es6
Changelog to 1.5.0
…s/unsubscribe # Conflicts: # CHANGELOG.md # src/browser/nylas-pro-migrator.es6
jstejada
force-pushed
the
master
branch
2 times, most recently
from
ef74afe to
6d2c2b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting to the default N1 keymaps does not also reset plugin keymaps to their defaults. Is this a feature or a bug?
We currently fetch the headers/body of each email thread by querying the Nylas API. This seems hacky, given that the email content is already available locally. Is there a better way to access this?
The unsubscribe keymap does not fire in the 2-panel view when the user is focused on the email body (anything inside .message-item-white-wrap). We are initializing a KeyCommandsRegion inside of our toolbar button — so is this some sort of scoping issue?