This repository was archived by the owner on Jun 26, 2020. It is now read-only.
Resolve -b option collision #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed -b alias for --benchmark option which collides with --background option.
|
Was this tested to confirm the new functionality works as behaved? Are you sure there are no other locations this change would need to occur? Looks fine to me, just following up |
|
Benchmark option is added in be4b0d7 and no codes are using |
mikeseese
approved these changes
Jul 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed -b alias for --benchmark option which collides with --background option.
Original issue here: nylas/nylas-mail#3464